Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a new RTB field and values on inputforms.xml #331

Closed
wants to merge 1 commit into from

Conversation

swebshet
Copy link

@swebshet swebshet commented Jul 6, 2017

I was doing the filed and values at the same time.It seems wrong

@alanorth alanorth self-requested a review July 6, 2017 12:53
@alanorth
Copy link
Member

alanorth commented Jul 6, 2017

Needs work. Look at the changes, there are character encoding issues, unrelated changes, and also, I think we should use the simple form of the names (without "Flagship 1" etc):

  • Enhanced genetic resources
  • Adapted productive varieties and quality seed
  • Resilient crops
  • Nutritious food and added value
  • Improved livelihoods at scale

@swebshet
Copy link
Author

swebshet commented Jul 6, 2017

Great I will do it again!!

@alanorth
Copy link
Member

alanorth commented Jul 6, 2017

Hi, I just talked to Abenet and she said that we can use collection names instead of making a new metadata field. So we don't need this anymore.

@alanorth alanorth closed this Jul 6, 2017
@swebshet
Copy link
Author

swebshet commented Jul 7, 2017 via email

@swebshet swebshet deleted the rtbflagship branch July 7, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants