Property hooks #82

iluuu1994 · 2023-05-01T20:32:31Z

No description provided.

…ssors) refs iluuu1994/php-src#82

{h,c} is not actually a supported pattern

Closes phpGH-11309

* PHP-8.2: [skip ci] Fix release date of PHP 8.2.7

Close phpGH-11312

* PHP-8.1: Access violation when ALLOC_FALLBACK fixed

* PHP-8.2: Access violation when ALLOC_FALLBACK fixed

…ceptions and segfaults with replaceWith This replaces the implementation of before and after with one following the spec very strictly, instead of trying to figure out the state we're in by looking at the pointers. Also relaxes the condition on text node copying to prevent working on a stale node pointer. Closes phpGH-11299.

* PHP-8.1: Fix phpGH-11288 and phpGH-11289 and phpGH-11290 and phpGH-9142: DOMExceptions and segfaults with replaceWith

* PHP-8.2: Fix phpGH-11288 and phpGH-11289 and phpGH-11290 and phpGH-9142: DOMExceptions and segfaults with replaceWith

…memory=1 The function repeatedly calls mprotect() which is extremely slow. In our community build, the Laravel tests went from ~6 minutes to ~4 hours. This issue only occurs with opcache.protect_memory=1. Closes phpGH-11323

* PHP-8.2: Fix zend_jit_stop_counter_handlers() performance issues with protect_memory=1

The var_dump can be preceded by the "Interactive shell" log. The var_dump does not add much to the test anyway, so just remove it.

* PHP-8.1: [skip ci] Fix race condition in readline test

* PHP-8.2: [skip ci] Fix race condition in readline test

Array literals will constant evaluate their elements. These can include assignments, even though these are not valid constant expressions. The lhs of assignments can be a list() element (or []) which is parsed as an array with a special flag.

This reverts commit 1c733c8. Fixes phpGH-11320

Zend/zend_property_hooks.c

…le namespaces The test was amended from the original issue report. For the test: Co-authored-by: php@deep-freeze.ca The problem is that the regular dom_reconcile_ns() only works on a single node. We actually have to reconciliate the whole tree in case a fragment was added. This also required to move some code around such that this special case could be handled separately. Closes phpGH-11362.

… with itself Closes phpGH-11363.

From the moment an ID is created, libxml2's behaviour is to cache that element, even if that element is not yet attached to the document. Similarly, only upon destruction of the element the ID is actually removed by libxml2. Since libxml2 has such behaviour deeply ingrained in the library, and uses the cache for various purposes, it seems like a bad idea and lost cause to fight it. Instead, we'll simply walk the tree upwards to check if the node is attached to the document. Closes phpGH-11369.

* PHP-8.1: Fix bug #77686: Removed elements are still returned by getElementById Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node with itself Fix bug #67440: append_node of a DOMDocumentFragment does not reconcile namespaces

* PHP-8.2: Fix bug #77686: Removed elements are still returned by getElementById Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node with itself Fix bug #67440: append_node of a DOMDocumentFragment does not reconcile namespaces

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

ikkez · 2023-06-15T12:16:41Z

Hi @iluuu1994
I have no idea how to get in contact and reach you through that php mailing list, but I am following the Property Hooks and the old property accessor RFC for feature a while now.

The base problem these RFCs try to solve is that we cannot intercept a public property's access, while it would be so useful. I'm here with you, but I'm thinking about a different solution that might just solve that problem in an easier way than hooks. If we'd just have a property flag to leave the public property uninitialized by default, we could fallback to the magic get/set method for it's access.
It's also possible right now, I've put it in here to show you what I mean https://3v4l.org/fQ4AG#v8.2.7
What do you think about that? Probably it's less type save by now, but maybe there's a solution for this somewhere. It would just make things so much easier to use and adapt for projects I guess.
kind regards, CK

KapitanOczywisty · 2023-06-15T19:14:11Z

The base problem these RFCs try to solve is that we cannot intercept a public property's access

And asymmetric visibility, and on-set validation, and virtual properties, and allow changes in logic without breaking API, and likely more.

I'm thinking about a different solution that might just solve that problem in an easier way than hooks

This would add new keyword for relatively low gain of single use case.

JoyceBabu · 2023-06-19T13:23:33Z

I am very much interested in this RFC and hope it will pass. But does this require reserving the keywords get and set? That would break every application depending on PSR-11.

iluuu1994 · 2023-06-19T13:26:22Z

get/set aren't keywords in this RFC, functions can continue using that name.

shaedrich · 2023-09-14T09:31:22Z

Is there a technical reason for throwing error for a redundant final keyword on both the property and the hook? I mean, would that be any harm? If not, I suspect, an E_NOTICE would suffice, wouldn't it?

Would it make sense, to add a jsonSerialize hook to the Future scope for get hooks that don't return a scalar value?

ghost · 2023-12-02T18:29:14Z

Hi, is it possible to merge upstream master and resolve conflicts?? I would like to build PHP from this branch and play around with this feature.

iluuu1994 · 2023-12-02T18:56:47Z

@javaDeveloperKid This branch is a bit outdated but functional. You can just check it out and build it like normal.

SerafimArts · 2024-02-04T01:51:35Z

closed this 3 days ago

~~I apologize, perhaps I did not see the necessary discussion in internals/externals, but do I understand correctly that work on adding properties to the php has been cancelled? =(~~

~~Frankly, adding property support was one of the most desirable possible future innovations in the PHP.next.~~

P.S. Whoops, didnt notice #122

github-actions bot added Category: Engine Category: Optimizer Extension: opcache Extension: reflection Extension: standard Extension: tokenizer Extension: zend_test labels May 1, 2023

iluuu1994 force-pushed the property-hooks branch from fce7c7f to 7a9dde4 Compare May 3, 2023 22:08

github-actions bot removed the Extension: zend_test label May 15, 2023

thekid mentioned this pull request May 15, 2023

Implement property hooks via virtual properties xp-framework/compiler#166

Merged

ThorstenSuckow added a commit to ThorstenSuckow/thorsten.suckow-homberg.de that referenced this pull request May 23, 2023

docs: add reference to property_hooks (next to Nikita's property_acce…

518a875

…ssors) refs iluuu1994/php-src#82

iluuu1994 and others added 17 commits May 24, 2023 20:45

[skip ci] Fix linguist-generated for zend_vm_opcodes files

5ff244d

{h,c} is not actually a supported pattern

Use single allocation for indirect values in array_multisort

eb7ec15

Closes phpGH-11309

[skip ci] Fix release date of PHP 8.2.7

150825d

Merge branch 'PHP-8.2'

04b1bc3

* PHP-8.2: [skip ci] Fix release date of PHP 8.2.7

Access violation when ALLOC_FALLBACK fixed

8946b7b

Close phpGH-11312

Merge branch 'PHP-8.1' into PHP-8.2

5b8e941

* PHP-8.1: Access violation when ALLOC_FALLBACK fixed

Merge branch 'PHP-8.2'

adb3d52

* PHP-8.2: Access violation when ALLOC_FALLBACK fixed

Merge branch 'PHP-8.1' into PHP-8.2

af72727

* PHP-8.1: Fix phpGH-11288 and phpGH-11289 and phpGH-11290 and phpGH-9142: DOMExceptions and segfaults with replaceWith

Merge branch 'PHP-8.2'

56b1c11

* PHP-8.2: Fix phpGH-11288 and phpGH-11289 and phpGH-11290 and phpGH-9142: DOMExceptions and segfaults with replaceWith

Merge branch 'PHP-8.2'

2d86e95

* PHP-8.2: Fix zend_jit_stop_counter_handlers() performance issues with protect_memory=1

[skip ci] Fix race condition in readline test

b5a07a7

The var_dump can be preceded by the "Interactive shell" log. The var_dump does not add much to the test anyway, so just remove it.

Merge branch 'PHP-8.1' into PHP-8.2

b47a7d4

* PHP-8.1: [skip ci] Fix race condition in readline test

Merge branch 'PHP-8.2'

58a191c

* PHP-8.2: [skip ci] Fix race condition in readline test

Revert "Use zend_ast_apply in zend_eval_const_expr (php#11261)"

fbe6696

This reverts commit 1c733c8. Fixes phpGH-11320

iluuu1994 commented May 26, 2023

View reviewed changes

Zend/zend_property_hooks.c Outdated Show resolved Hide resolved

iluuu1994 force-pushed the property-hooks branch from 1db6162 to 1b36c95 Compare May 27, 2023 09:12

nielsdos and others added 6 commits June 4, 2023 16:19

Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node…

23f7002

… with itself Closes phpGH-11363.

Merge branch 'PHP-8.1' into PHP-8.2

5b79c53

* PHP-8.1: Fix bug #77686: Removed elements are still returned by getElementById Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node with itself Fix bug #67440: append_node of a DOMDocumentFragment does not reconcile namespaces

Merge branch 'PHP-8.2'

e8fb0ed

* PHP-8.2: Fix bug #77686: Removed elements are still returned by getElementById Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node with itself Fix bug #67440: append_node of a DOMDocumentFragment does not reconcile namespaces

Accessors implementation

4d4a5ab

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

iluuu1994 force-pushed the property-hooks branch from 836c819 to 4d4a5ab Compare June 5, 2023 08:18

github-actions bot added Extension: bcmath Extension: dom Extension: ffi Extension: libxml Extension: mbstring Extension: simplexml Extension: spl SAPI: cli SAPI: phpdbg Extension: readline Extension: xsl labels Jun 5, 2023

iluuu1994 added 2 commits June 6, 2023 23:11

Basic json_encode support

62369cc

Implement get_object_vars

1137c18

github-actions bot added the Extension: json label Jun 6, 2023

iluuu1994 closed this Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Property hooks #82

Property hooks #82

iluuu1994 commented May 1, 2023 •

edited

Loading

ikkez commented Jun 15, 2023

KapitanOczywisty commented Jun 15, 2023

JoyceBabu commented Jun 19, 2023

iluuu1994 commented Jun 19, 2023

shaedrich commented Sep 14, 2023 •

edited

Loading

ghost commented Dec 2, 2023 •

edited by ghost

Loading

iluuu1994 commented Dec 2, 2023

SerafimArts commented Feb 4, 2024 •

edited

Loading

Property hooks #82

Property hooks #82

Conversation

iluuu1994 commented May 1, 2023 • edited Loading

ikkez commented Jun 15, 2023

KapitanOczywisty commented Jun 15, 2023

JoyceBabu commented Jun 19, 2023

iluuu1994 commented Jun 19, 2023

shaedrich commented Sep 14, 2023 • edited Loading

ghost commented Dec 2, 2023 • edited by ghost Loading

iluuu1994 commented Dec 2, 2023

SerafimArts commented Feb 4, 2024 • edited Loading

iluuu1994 commented May 1, 2023 •

edited

Loading

shaedrich commented Sep 14, 2023 •

edited

Loading

ghost commented Dec 2, 2023 •

edited by ghost

Loading

SerafimArts commented Feb 4, 2024 •

edited

Loading