-
-
Notifications
You must be signed in to change notification settings - Fork 27.3k
Issue 893 #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 893 #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing due to checkstyle errors
factory-method/src/main/java/com/iluwatar/factory/method/ElfBlacksmith.java
Outdated
Show resolved
Hide resolved
factory-method/src/main/java/com/iluwatar/factory/method/ElfBlacksmith.java
Outdated
Show resolved
Hide resolved
factory-method/src/main/java/com/iluwatar/factory/method/ElfBlacksmith.java
Outdated
Show resolved
Hide resolved
@hbothra15 some changes were requested |
Yes @iluwatar, |
Let me know when it's ready for another review |
It's ready for your review |
System.out.println(clazz); | ||
System.out.println(weapon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either remove these console printouts or use proper logger
Changes has been made and updated the README.md file to be aligned with new code |
Thanks a lot @hbothra15 👍 |
Static factory method
Pull request description