Skip to content

Conversation

dgruntz
Copy link
Contributor

@dgruntz dgruntz commented Nov 17, 2019

Adds a comment that the template method should be declared final (as discussed in Issue #1099).
Moreover a real-world example is added.

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's documentation changes, but the actual changing the method to final is not present (anymore).

@dgruntz
Copy link
Contributor Author

dgruntz commented Nov 18, 2019

I see there's documentation changes, but the actual changing the method to final is not present (anymore).

The actual change has been submitted as a separate pull request (#1100). I first only changed the code (in #1100) and then in another branch changed the documentation (#1101), but unfortunately I branched off this new branch from the wrong branch and then mannyally reverted the code change.

There is a problem with the other pull request, namely that the tests do not pass (a problem with mockito and its unability to work with final methods). Due to this problem I think it was a good idea to separate these changes in separate pull requests.

@iluwatar iluwatar added this to the 1.23.0 milestone Nov 19, 2019
@iluwatar iluwatar merged commit 1fbe9bb into iluwatar:master Nov 19, 2019
@iluwatar
Copy link
Owner

Thanks @dgruntz for this contribution.

@iluwatar
Copy link
Owner

#1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants