Abstract document add module info file #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iluwatar Can you please suggest if this PR is ok? Thank you. |
iluwatar
requested changes
Jan 4, 2020
| @@ -0,0 +1,2 @@ | |||
| module abstractdocument.modules { | |||
| } No newline at end of file | |||
There was a problem hiding this comment.
I would prefer format like this:
module com.iluwatar.abstractdocument {
}
There was a problem hiding this comment.
The build is failing with package org.slf4j is not visible (package org.slf4j is declared in the unnamed module, but module org.slf4j does not read it)
To fix it you need to declare something like this inside the module-info:
requires org.slf4j;
There was a problem hiding this comment.
@iluwatar Thank you for your comments. I have done the required changes. Can you please suggest?
iluwatar
approved these changes
Jan 11, 2020
|
Thanks @saksham93, first one down only a few to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title
Abstract document add module info file. Refers to #1047
Pull request description
Added module-info.java file in Abstract Document Design pattern.
If this is the correct way, will add it to more design patterns.