Declares the template method as final (Issue 1099) #2057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #1099 it is recommended to declare the template method as final.
This pull request changes the implementation in the sample code of the template method pattern.
This change is applied both in the sample code and in the documentation.
Moreover, the tests was adjusted. As Mockito has problems with
final
methods, the Mockito dependency had to be changed frommockito-core
tomockito-inline
.The tests pass: