#229 Page Object Pattern #434

colinbut · 2016-06-18T20:46:03Z

I created a sample application sub-module which just contains the App.java driver class that runs the sample web app (which is just a simple web site really for demonstration purposes). App.java does nothing special apart from just tries to open up the web app in default web browser.Another sub-module test-automation is as the name suggest a test module which contains the page objects and the test classes that uses these page objects.

Normally, an automation framework/tool like Selenium will be used for test automation utilising the Page Objects but for the purpose of demonstrating this pattern implementation i've used a simple library HtmlUnit instead as Selenium is very heavyweight and i wanted the pattern example to focus on how the pattern is normally implemented.

coveralls · 2016-06-18T21:08:01Z

Coverage decreased (-0.3%) to 89.219% when pulling 0282d66 on colinbut:master into f57b94a on iluwatar:master.

iluwatar · 2016-06-25T17:28:54Z

Review comments:

Page-object contains two submodules - is this necessary or could we implement the sample application in the src/main/java and the test code in src/test/java?
In general you should use final keyword for members when they are initialized in constructor

iluwatar · 2016-06-25T17:32:56Z

page-object/sample-application/src/main/resources/credentials.txt

+====
+
+username - admin
+password - password


Is this file used?

intention was for informational purpose only.
i'll remove this file

iluwatar · 2016-06-25T17:42:52Z

@colinbut you have my review remarks. Please comment once you've implemented the changes and I'll take another look.

colinbut · 2016-06-27T19:38:11Z

Page-object contains two submodules - is this necessary or could we implement the sample application in the src/main/java and the test code in src/test/java?

on terms of whether it is necessary you could argue it both ways. The tests are not unit tests so my initial implementation was to put it in a separate module at least. Since, normally in real-world these are full end to end integration tests which normally resides in a separate project/module etc.

But on reflection maybe it is more sensible to put into one module since those are the only tests for this example.

I can certainly combine them together as you suggested.

@iluwatar would you like me to do that?

coveralls · 2016-06-27T20:18:28Z

Coverage decreased (-0.6%) to 88.474% when pulling 35c0942 on colinbut:master into e7bd3ca on iluwatar:master.

iluwatar · 2016-06-28T18:33:22Z

@iluwatar would you like me to do that?

Yes, please. I think it is better that way.

coveralls · 2016-07-03T21:34:28Z

Coverage decreased (-0.4%) to 88.985% when pulling ef2ada4 on colinbut:master into 5c26f46 on iluwatar:master.

colinbut · 2016-07-06T19:18:05Z

@iluwatar done changes from your initial feedback

iluwatar · 2016-07-09T08:19:04Z

I have problems running the example. In Eclipse when I run the App.java I get Exception in thread "main" java.lang.IllegalArgumentException: The file: /home/ilkka/java-design-patterns/page-object/page-object/src/main/resources/sample-ui/login.html doesn't exist. The same happens on the command line when I do mvn exec:java -Dexec.mainClass="com.iluwatar.pageobject.App" in the page-object folder.

In App.java should it be File applicationFile = new File(currentWorkingDir + "/src/main/resources/sample-ui/login.html");?

iluwatar · 2016-07-09T08:20:58Z

The license headers are missing from two files:

[INFO] Updating license header in: /home/ilkka/java-design-patterns/page-object/src/main/resources/sample-ui/css/style.css
[INFO] Updating license header in: /home/ilkka/java-design-patterns/page-object/src/main/resources/sample-ui/css/album-list.css

iluwatar · 2016-07-09T08:22:53Z

When running tests I get this nasty looking exception although the passes. Do you know what might cause this?

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.iluwatar.pageobject.AlbumListPageTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.339 sec - in com.iluwatar.pageobject.AlbumListPageTest
Running com.iluwatar.pageobject.LoginPageTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec - in com.iluwatar.pageobject.LoginPageTest
Running com.iluwatar.pageobject.AlbumPageTest
java.lang.instrument.IllegalClassFormatException: Error while instrumenting class com/steadystate/css/parser/SACParserCSS3TokenManager.
    at org.jacoco.agent.rt.internal_b0d6a23.CoverageTransformer.transform(CoverageTransformer.java:95)
    at sun.instrument.TransformerManager.transform(TransformerManager.java:188)
    at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:428)
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
    at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
    at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
    at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
    at com.steadystate.css.parser.SACParserCSS3.<init>(SACParserCSS3.java:3272)
    at com.steadystate.css.parser.SACParserCSS3.<init>(SACParserCSS3.java:33)
    at com.gargoylesoftware.htmlunit.javascript.host.css.CSSStyleSheet.parseCSS(CSSStyleSheet.java:929)
    at com.gargoylesoftware.htmlunit.javascript.host.css.CSSStyleSheet.<init>(CSSStyleSheet.java:199)
    at com.gargoylesoftware.htmlunit.javascript.host.css.CSSStyleSheet.loadStylesheet(CSSStyleSheet.java:367)
    at com.gargoylesoftware.htmlunit.javascript.host.html.HTMLLinkElement.getSheet(HTMLLinkElement.java:145)
    at com.gargoylesoftware.htmlunit.javascript.host.css.StyleSheetList.item(StyleSheetList.java:182)
    at com.gargoylesoftware.htmlunit.javascript.host.Window.getComputedStyle(Window.java:1590)
    at com.gargoylesoftware.htmlunit.html.HtmlSerializer.appendNode(HtmlSerializer.java:276)
    at com.gargoylesoftware.htmlunit.html.HtmlSerializer.asText(HtmlSerializer.java:62)
    at com.gargoylesoftware.htmlunit.html.HtmlOption.getText(HtmlOption.java:395)
    at com.gargoylesoftware.htmlunit.html.HtmlOption.getValueAttribute(HtmlOption.java:226)
    at com.gargoylesoftware.htmlunit.html.HtmlSelect.getOptionByValue(HtmlSelect.java:471)
    at com.iluwatar.pageobject.pages.AlbumPage.changeAlbumYear(AlbumPage.java:112)
    at com.iluwatar.pageobject.AlbumPageTest.testSaveAlbum(AlbumPageTest.java:48)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.junit.runners.Suite.runChild(Suite.java:128)
    at org.junit.runners.Suite.runChild(Suite.java:27)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
    at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:108)
    at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:78)
    at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:54)
    at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:144)
    at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Caused by: java.io.IOException: Error while instrumenting class com/steadystate/css/parser/SACParserCSS3TokenManager.
    at org.jacoco.agent.rt.internal_b0d6a23.core.instr.Instrumenter.instrumentError(Instrumenter.java:152)
    at org.jacoco.agent.rt.internal_b0d6a23.core.instr.Instrumenter.instrument(Instrumenter.java:103)
    at org.jacoco.agent.rt.internal_b0d6a23.CoverageTransformer.transform(CoverageTransformer.java:93)
    ... 64 more
Caused by: java.lang.RuntimeException: Method code too large!
    at org.jacoco.agent.rt.internal_b0d6a23.asm.MethodWriter.getSize(MethodWriter.java:2036)
    at org.jacoco.agent.rt.internal_b0d6a23.asm.ClassWriter.toByteArray(ClassWriter.java:827)
    at org.jacoco.agent.rt.internal_b0d6a23.core.instr.Instrumenter.instrument(Instrumenter.java:84)
    at org.jacoco.agent.rt.internal_b0d6a23.core.instr.Instrumenter.instrument(Instrumenter.java:101)
    ... 65 more
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.25 sec - in com.iluwatar.pageobject.AlbumPageTest

iluwatar · 2016-07-09T08:23:31Z

Those are my comments for now. @colinbut looking forward to your response.

coveralls · 2016-07-10T20:14:31Z

Coverage decreased (-0.2%) to 89.205% when pulling f182e87 on colinbut:master into 5c26f46 on iluwatar:master.

colinbut · 2016-07-11T09:29:27Z

I use Intellij IDEA for development. Intellij and Eclipse handles multi-module project very differently from each other.

I've reworked that area. File applicationFile = new File(currentWorkingDir + "/src/main/resources/sample-ui/login.html"); would not be a good fix in my opinion. Since the sample app lives under resources i've let java to load it from interpretation now.

colinbut · 2016-07-11T09:30:23Z

The license headers are missing from two files:

[INFO] Updating license header in: /home/ilkka/java-design-patterns/page-object/src/main/resources/sample-ui/css/style.css
[INFO] Updating license header in: /home/ilkka/java-design-patterns/page-object/src/main/resources/sample-ui/css/album-list.css

have now added the license headers to these 2 files

colinbut · 2016-07-11T09:34:44Z

Ah, this is my oversight. The test actually passes despite the exception and the build passes.

This is actually caused by JaCoCo code coverage trying to instrument the underlying library class in the HtmlUnit library i'm using. This is causing a problem because that class in culprit has a massive over 4000+ lines of code in a single method.

I've added an exclusion to the list of exclusions already there since i don't believe this should be part of the code coverage

colinbut · 2016-07-11T09:35:26Z

@iluwatar my responses are in comments above.

iluwatar · 2016-07-12T16:47:41Z

Thanks for the latest updates. Everything seems to work as expected. Good job @colinbut 👍

iluwatar · 2020-07-28T14:51:43Z

@all-contributors please add @colinbut for code

allcontributors · 2020-07-28T14:51:51Z

@iluwatar

I've put up a pull request to add @colinbut! 🎉

colinbut added 3 commits June 18, 2016 15:40

Page Object pattern implementation

53fc8b7

added Class Diagram

c8f04d2

README

0282d66

colinbut mentioned this pull request Jun 18, 2016

Page Object pattern #229

Closed

iluwatar added the status: under review label Jun 25, 2016

iluwatar self-assigned this Jun 25, 2016

iluwatar reviewed Jun 25, 2016
View reviewed changes

syncing fork

35c0942

colinbut added 9 commits June 28, 2016 21:53

Feedback changes - restructed project structure

27e4e9a

Feedback changes - sort out dependency

8efaf44

Feedback changes - fix dependency in pom

c212ee5

Feedback changes - removed file

4eac37c

Feedback changes - final and refactored code

b1e40d9

remove old class diagram

8832189

new class diagrams

4a069ee

syncing fork

5d58a1b

syncing fork

ef2ada4

colinbut added 3 commits July 9, 2016 22:20

added missing licence headers to 2 files

7be98fa

exclude library class from jacoco code coverage

85f432f

fixed app launch

f182e87

iluwatar merged commit b46d2de into iluwatar:master Jul 12, 2016

allcontributors bot mentioned this pull request Jul 28, 2020

docs: add colinbut as a contributor #1364

Merged

Uh oh!

#229 Page Object Pattern #434

#229 Page Object Pattern #434

Uh oh!

Conversation

colinbut commented Jun 18, 2016

Uh oh!

coveralls commented Jun 18, 2016

Uh oh!

iluwatar commented Jun 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iluwatar Jun 25, 2016

Choose a reason for hiding this comment

Uh oh!

colinbut Jun 27, 2016

Choose a reason for hiding this comment

Uh oh!

iluwatar commented Jun 25, 2016

Uh oh!

colinbut commented Jun 27, 2016

Uh oh!

coveralls commented Jun 27, 2016

Uh oh!

iluwatar commented Jun 28, 2016

Uh oh!

coveralls commented Jul 3, 2016

Uh oh!

colinbut commented Jul 6, 2016

Uh oh!

iluwatar commented Jul 9, 2016

Uh oh!

iluwatar commented Jul 9, 2016

Uh oh!

iluwatar commented Jul 9, 2016

Uh oh!

iluwatar commented Jul 9, 2016

Uh oh!

coveralls commented Jul 10, 2016

Uh oh!

colinbut commented Jul 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colinbut commented Jul 11, 2016

Uh oh!

colinbut commented Jul 11, 2016

Uh oh!

colinbut commented Jul 11, 2016

Uh oh!

iluwatar commented Jul 12, 2016

Uh oh!

iluwatar commented Jul 28, 2020

Uh oh!

allcontributors bot commented Jul 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iluwatar commented Jun 25, 2016 •

edited

Loading

colinbut commented Jul 11, 2016 •

edited

Loading