[WIP] Data Bus #544
Merged
[WIP] Data Bus #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@kemitix in general the example looks fine. Here are some things we still need to do before merging:
|
iluwatar
requested changes
Mar 11, 2017
data-bus/pom.xml
Outdated
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> |
There was a problem hiding this comment.
I'm not sure why maven-surefire-plugin is needed? Can we leave it out?
| /** | ||
| * The Data Bus pattern | ||
| * <p> | ||
| * <p>{@see http://wiki.c2.com/?DataBusPattern}</p> |
There was a problem hiding this comment.
Please describe the pattern here. Also add description how the example implements the pattern.
|
@kemitix any update on this? |
|
Sorry. Been caught up in other projects. Will update this later today.
|
* upstream/master: (67 commits) Set version for next development iteration Reached milestone 1.15.0 #539 Checkstyle fix #539 More Checkstyle fixes #539 Checkstyle fixes #497 Add missing puml and license headers #77 Add missing license header Work on #190: urm/puml updates * added pumlid where it was missing and possible * removed pumlid where it generated a bad image * regenerated some incorrect puml's * added 'left to right direction' puml prefix to some diagrams to improve the automatic layouting Removed AvoidStarImport Rule Added JavaDocType Rule Update App.java Update App.java Update after changes from review. Additional improvements. Pom.xml files fixed. #66 Balking Pattern fixed pmd violation fixed checkstyle violations diagrams added comments, tests and description changed parent POM version #69 apply changes from review #69 ... # Conflicts: # pom.xml
from the MessageData that it receives.
|
@kemitix ready for another review? |
|
@iluwatar Sure. |
iluwatar
approved these changes
Apr 22, 2017
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <properties> | ||
| <lombok.version>1.16.14</lombok.version> |
There was a problem hiding this comment.
Remove this line since lombok is not used
|
@all-contributors please add @kemitix for code |
|
I've put up a pull request to add @kemitix! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #467