508 : Sonar qube critical Issue Fix #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed.
Define a constant instead of duplicating this literal " does not exist." 3 times.
Define a constant instead of duplicating this literal "Some external api for only realtime execution could be called here." 3 times.
|
Please review and merge |
|
@iluwatar Can you assign someone to review this and merge |
iluwatar
approved these changes
Jul 28, 2019
|
Thanks for this too @kanwarpreet25 😄 |
hoangnam2261
pushed a commit
to hoangnam2261/java-design-patterns
that referenced
this pull request
Jul 30, 2019
* 508 : Sonar qube critical Issue Fix Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. * 508: Sonar Qube Issue fxes Define a constant instead of duplicating this literal " does not exist." 3 times. * 508: sonar qube issue fixes Define a constant instead of duplicating this literal "Some external api for only realtime execution could be called here." 3 times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed.
Pull request title
Pull request description