-
-
Notifications
You must be signed in to change notification settings - Fork 27.3k
#970 single logging framework should be enforced #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#970 single logging framework should be enforced #982
Conversation
@jjjimenez100 please resolve the conflict |
Fixed by bf2b3cb Although I'm not really sure that was the best way to fix the conflict since I did it on Ghub's UI. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but log4j is still present in several places. You can try to grep the codebase like grep -r -l "log4j"
to see where it is still referenced.
Ah right. About that, I think the only remaining are the ones under the |
It's ok for me to remove those statements. It would be also good to scan for |
bf2b3cb
to
0a1cc7f
Compare
This also removes the aws log4j dependency
0a1cc7f
to
1f34630
Compare
The only remnants of
since the examples has test cases asserting the output from the console (which I believe the way the example was structured to begin with) For the log4j ones, stuffs remaining are on |
Thanks @jjjimenez100 for the hard work you've done |
Replaces all usages of log4j with the Slf4j API. This PR also removes references of log4j in pom and resource files.