Update: adding a defaultView to the shadow root #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevematney
force-pushed
the
default-view
branch
from
4eeaf15 to
f389fa9
Compare
Nayshlok
approved these changes
Mar 31, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "react-html-element", | |||
| "version": "0.0.1", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Just curious was this supposed to have been bumped up earlier? Asking because this doesn't seem like a major change.
There was a problem hiding this comment.
Should have been, but this is harmless since it's just the lock file.
There was a problem hiding this comment.
Like Alex said, this is getting updated because the package.json is already at v1, but the package-lock hadn't been regenerated with the new version.
Ultimately, it shouldn't matter since semantic-release should update it anyway.
aabenoja
approved these changes
Mar 31, 2020
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UI libraries expect the root node to have a
defaultView. This provides that value.