Skip to content

docs: improve glossary #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2023
Merged

docs: improve glossary #33

merged 4 commits into from
Sep 13, 2023

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Sep 4, 2023 that may be closed by this pull request
@stropitek
Copy link
Contributor

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 394b626
Status: ✅  Deploy successful!
Preview URL: https://508cb84e.image-js-docs.pages.dev
Branch Preview URL: https://29-feedback-on-glossary.image-js-docs.pages.dev

View logs

@stropitek
Copy link
Contributor

I'm wondering if we should remove the definition of "intensity", or maybe give it a narrow definition which fits in the context of image-js.

Because the definition is actually not very well defined for digital image processing. It's clear what it is for grey images but ambiguous, but not for multi-channel images. Can you review where this term is used in the library (parameters, method names etc...) and report it in an issue? We can leave it like it is for this PR.

especially in color images, where each channel represents a primary color or a specific property of the image

I think it's more a specific property of each pixel than of the image.

Mask in imageJS is a class that represents binary data from the image...

I would say masks are a special "class" of 1-bit depth, single channel images, rather than the "grid of binary data" definition.

A ROI (Region of Interest) map, also known as segmentation map, is a binary image that highlights regions of interest within a larger image

Do we really need this definition? Do we reference ROI maps anywhere in the public methods of image-js?

@EscapedGibbon
Copy link
Contributor Author

I'm wondering if we should remove the definition of "intensity", or maybe give it a narrow definition which fits in the context of image-js.

Because the definition is actually not very well defined for digital image processing. It's clear what it is for grey images but ambiguous, but not for multi-channel images. Can you review where this term is used in the library (parameters, method names etc...) and report it in an issue? We can leave it like it is for this PR.

especially in color images, where each channel represents a primary color or a specific property of the image

I think it's more a specific property of each pixel than of the image.

Mask in imageJS is a class that represents binary data from the image...

I would say masks are a special "class" of 1-bit depth, single channel images, rather than the "grid of binary data" definition.

A ROI (Region of Interest) map, also known as segmentation map, is a binary image that highlights regions of interest within a larger image

Do we really need this definition? Do we reference ROI maps anywhere in the public methods of image-js?

The intensity is used as a term in centroidIntensity and watershed. I believe they define intensity the same way it is defined in glossary.

We also have ROI as a separate class which comes from Mask and can create a ROI map. I am not sure yet how ROI will be documented but it will certainly be important to understand these terms outside of ROI documentation.

@stropitek stropitek merged commit 76fdda6 into main Sep 13, 2023
@stropitek stropitek deleted the 29-feedback-on-glossary branch September 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback on glossary
2 participants