Skip to content

docs: add watershed filter page #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 19, 2024

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa867af
Status: ✅  Deploy successful!
Preview URL: https://0db926cd.image-js-docs.pages.dev
Branch Preview URL: https://74-add-an-example-with-water.image-js-docs.pages.dev

View logs

@EscapedGibbon EscapedGibbon force-pushed the 74-add-an-example-with-watershed-filter branch from 39770bc to 76917c0 Compare November 22, 2023 14:30
@EscapedGibbon EscapedGibbon marked this pull request as ready for review November 22, 2023 14:31
@EscapedGibbon EscapedGibbon marked this pull request as draft November 24, 2023 07:24
@EscapedGibbon EscapedGibbon marked this pull request as ready for review November 24, 2023 11:23
@stropitek
Copy link
Contributor

CleanShot 2023-11-28 at 15 55 25

The input image could also contain the points which were used as an input (with red dots similar to elsewhere)

@EscapedGibbon EscapedGibbon force-pushed the 74-add-an-example-with-watershed-filter branch from 6569861 to e7aa033 Compare December 4, 2023 09:45
@EscapedGibbon EscapedGibbon marked this pull request as draft December 4, 2023 14:14
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation in watershed is not really describing the implementation.

Try to move what seems important to the main section of the watershed documentation page

@EscapedGibbon EscapedGibbon marked this pull request as ready for review December 22, 2023 14:37
@stropitek
Copy link
Contributor

When you use parethesis, you are not formatting them correctly. There should be a space before the opening parenthesis.

I need your input on some of the explanations which don't seem correct or clear to me. Let's setup a meeting.

@EscapedGibbon EscapedGibbon marked this pull request as draft January 5, 2024 09:53
@EscapedGibbon EscapedGibbon force-pushed the 74-add-an-example-with-watershed-filter branch from 97c97e3 to 887a4a3 Compare January 10, 2024 09:36
@EscapedGibbon EscapedGibbon marked this pull request as ready for review January 10, 2024 09:37
@stropitek stropitek merged commit f72454a into main Jan 19, 2024
@stropitek stropitek deleted the 74-add-an-example-with-watershed-filter branch January 19, 2024 09:41
EscapedGibbon added a commit that referenced this pull request Jan 24, 2024
* docs wip add watershed filter page

* docs: add example of watershed

* docs: minor fixes

* docs: small fix in formatting

* docs: add exception in cspell

* docs: temporarily put watershed demo in comments

* docs: expand watershed explanation

* docs: add a better example of blurring

* docs: specify points in the watershed example

* docs: finalize watershed pr

* docs: add links to watershed options

* docs: fix spellcheck

* docs: add links to github io and improve phrasing

* docs: remove duplicated image

* docs: clarify nd reformat text for watershed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add an example with watershed filter
2 participants