This repository was archived by the owner on Jul 26, 2025. It is now read-only.
246 new roi property ellipse #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 98.47% 98.49% +0.01%
==========================================
Files 196 197 +1
Lines 5127 5173 +46
Branches 1114 1115 +1
==========================================
+ Hits 5049 5095 +46
Misses 76 76
Partials 2 2
☔ View full report in Codecov by Sentry. |
lpatiny
suggested changes
Apr 20, 2023
lpatiny
reviewed
Apr 20, 2023
lpatiny
reviewed
Apr 20, 2023
lpatiny
reviewed
Apr 21, 2023
…ge-js/image-js-typescript into 246-new-roi-property-ellipse
lpatiny
approved these changes
Apr 24, 2023
targos
reviewed
Apr 24, 2023
targos
reviewed
Apr 24, 2023
targos
reviewed
Apr 24, 2023
…ge-js/image-js-typescript into 246-new-roi-property-ellipse
|
@EscapedGibbon Please add the following test case as well 0 1 0 Currently it yields to NaN. Could be improved in the future. |
lpatiny
reviewed
Apr 25, 2023
lpatiny
reviewed
Apr 25, 2023
|
I can have a look, but in the end it's @lpatiny who knows best about this feature |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.