Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh fuzzing corpus again following the fix of #222 #228

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

Shnatsel
Copy link
Contributor

Increases edge coverage from ~1500 to ~1950. Also shrinks the corpus to 615Kb.

@HeroicKatora
Copy link
Member

HeroicKatora commented Jun 19, 2020

That's a good increase in coverage. We should think about how and when to do this in the future. Every changed file in the corpus is permanently part of the git history and we probably don't want to have a situation where you first download 1Gb of old fuzzing corpora on a fresh clone.

@aschampion
Copy link
Contributor

What about moving the fuzzing into a separate repo tracked via a submodule (or the opposite with the png repo tracked via submodule in the fuzzer repo), so only CI and people interested in running the fuzzer have to check it out, and can usually get by with a shallow clone?

@Shnatsel
Copy link
Contributor Author

I hoped that that such changes would be infrequent enough not to become a problem. I've re-generated the corpus following the switch to miniz_oxide and then again after I found that the fuzzing target was broken and fixed it (#222). Prior to that the fuzzing corpus was untouched for about a year. I think an extra ~2Mb of git history per year should be tolerable.

@HeroicKatora
Copy link
Member

HeroicKatora commented Jun 19, 2020

It's mostly the current influx that worried me, the last month. We shouldn't let this become the new norm. In particular you may want to wait for #227 which might also change the coverage by opening the possibility of fuzzing on 32-bit targets.

@HeroicKatora HeroicKatora merged commit 1f0cdfe into image-rs:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants