Repository navigation
Replies: 1 comment
|
Perhaps not directly an answer to your question, but I should warn that I've pretty much stopped reviewing PRs since I realized that it was no longer fun for me. At some point I might write out my thoughts in more detail, but the short version is just thinking through what the (unpaid) work had become: I'd been spending my weekends fixing bugs to benefit corporate employees as part of their jobs, or taking 30-60 minutes each to review PRs that I suspect in many cases took only 10-20 minutes (or less) to make. That combined with the exponential growth of Rust just made the whole thing unsustainable. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Like many other libraries,
imagehas accumulated a large list of minor issues that anyone or any program auditing the code can find and report. (And make PRs for.) Identifying and fixing all of the actual issues, while useful, will require a lot of time and review, which distracts from making larger improvements to the library.@197g , @fintelia, @RunDevelopment : please let me know if me reviewing any or all of the existing PRs would be useful. (Even those which appear dead and have merge conflicts, as other people may resurrect them in the future.) We likely disagree on many API design questions, but I can often at least test things, guess at how users are actually using the interfaces, compare with how the other libraries I've used handle things, check for bugs or likely future issues, or give opinions on specific API changes.
All reactions