Added transformation, e-shadow, e-gradient parameter #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 95.54% 95.98% +0.43%
==========================================
Files 9 9
Lines 202 224 +22
Branches 50 59 +9
==========================================
+ Hits 193 215 +22
Misses 1 1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
imagekitio
reviewed
Jan 22, 2024
imagekitio
reviewed
Jan 22, 2024
imagekitio
reviewed
Jan 22, 2024
added 10 commits
January 24, 2024 09:30
ahnv
suggested changes
Jan 25, 2024
imagekitio
reviewed
Jan 30, 2024
src/constants/supportedTransforms.ts
Outdated
| effectShadow: "e-shadow", | ||
|
|
||
| /** | ||
| * @link https://docs.imagekit.io/features/image-transformations/image-enhancement-and-color-manipulation.md#gradient-e-gradient |
There was a problem hiding this comment.
imagekitio
reviewed
Jan 30, 2024
imagekitio
reviewed
Jan 30, 2024
test/upload.js
Outdated
| await sleep(); | ||
| var errRes = { | ||
| help: "", | ||
| message: "Invalid transformation parameter.", |
There was a problem hiding this comment.
Error message is not helpful to user. We can add a valid example like we do in our transformation parser. Append a generic valid example sentence in the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.