Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Workflow failure does not allow retry. #64

Closed
erikng opened this issue May 1, 2015 · 10 comments
Closed

Workflow failure does not allow retry. #64

erikng opened this issue May 1, 2015 · 10 comments
Assignees

Comments

@erikng
Copy link
Contributor

erikng commented May 1, 2015

If Imagr fails to pull down any component of the workflow, you do not have the ability to retry. You can hit "OK" Which will then bring up Startup Disk. Imagr is blank and only allows you to quit. Quitting Imagr (when using AutoNBI) causes it to load the normal recovery.

@grahamgilbert
Copy link
Collaborator

This is largely by design. The only improvement I can think of would be to disable the quit item so the app can't be quit without restarting. What failures would a retry solve? The only ones I can think of are:

  • 404 for image or package
  • pre boot script or package install failure
  • restore failure (which admittedly might be a temporary network problem, but I think that's an edge case).

@natewalck
Copy link

Imagr doesn't allow you to continue unless there is already a partition present, so that averts local disk issues, correct?

@grahamgilbert, I assume your thinking is that if the workflow fails, then it was not crafted well? As in, if a workflow fails, you shouldn't fiddle with things locally until it works, you should fix the workflow.

@erikng
Copy link
Contributor Author

erikng commented May 1, 2015

By "retry" I mean allowing someone to pick a workflow again, not retry from the current location.

When DeployStudio fails, you are allowed to quit or continue. Continue takes you back to the workflow area to reselect.

@natewalck
Copy link

I think the question is...if the workflow fails once, when would running it again have a different outcome?

@erikng
Copy link
Contributor Author

erikng commented May 1, 2015

When it's been fixed and I "refresh workflows" with the new button.

@natewalck
Copy link

Ah, I see. So instead of bailing the whole app, bail back to the selector.

@erikng
Copy link
Contributor Author

erikng commented May 1, 2015

Exactly. :)

@grahamgilbert
Copy link
Collaborator

At the moment, there's one kind of failure - one that results in the error modal. It seems like we need two kinds of failure. Hard failures where nothing can continue (no config plist etc) and those that can dump you back to the select workflow screen.

@grahamgilbert grahamgilbert self-assigned this May 7, 2015
@gmarnin
Copy link

gmarnin commented May 12, 2015

I ran into this today. I had a mistake in my image_config.plist which I fixed but was unable to click on refresh workflows because it was grey out.

@grahamgilbert
Copy link
Collaborator

Fixed in 55ba856

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants