-
Notifications
You must be signed in to change notification settings - Fork 53
Workflow failure does not allow retry. #64
Comments
This is largely by design. The only improvement I can think of would be to disable the quit item so the app can't be quit without restarting. What failures would a retry solve? The only ones I can think of are:
|
Imagr doesn't allow you to continue unless there is already a partition present, so that averts local disk issues, correct? @grahamgilbert, I assume your thinking is that if the workflow fails, then it was not crafted well? As in, if a workflow fails, you shouldn't fiddle with things locally until it works, you should fix the workflow. |
By "retry" I mean allowing someone to pick a workflow again, not retry from the current location. When DeployStudio fails, you are allowed to quit or continue. Continue takes you back to the workflow area to reselect. |
I think the question is...if the workflow fails once, when would running it again have a different outcome? |
When it's been fixed and I "refresh workflows" with the new button. |
Ah, I see. So instead of bailing the whole app, bail back to the selector. |
Exactly. :) |
At the moment, there's one kind of failure - one that results in the error modal. It seems like we need two kinds of failure. Hard failures where nothing can continue (no config plist etc) and those that can dump you back to the select workflow screen. |
I ran into this today. I had a mistake in my image_config.plist which I fixed but was unable to click on refresh workflows because it was grey out. |
Fixed in 55ba856 |
If Imagr fails to pull down any component of the workflow, you do not have the ability to retry. You can hit "OK" Which will then bring up Startup Disk. Imagr is blank and only allows you to quit. Quitting Imagr (when using AutoNBI) causes it to load the normal recovery.
The text was updated successfully, but these errors were encountered: