-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip github repos #522
skip github repos #522
Conversation
Looks like there's a bug here. In I guess the solution is to use a new array and populate it with elements in
|
if(skips.length > 0){ | ||
for(var i=0; i < repos.length; i++){ | ||
if(skips.indexOf(repos[i].name) >= 0){ | ||
repos.splice(i,1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't call repos.splice
inside of loop through repos.length
because splicing (in this case removing an element) changes the length of repos
, therefore not all elements will be iterated over.
My solution is (from line 32):
Tested against all edge cases. My javascript skills aren't flash, so there may well be a much nicer way to do this. |
We've made it so that you have to explicitly include them via your configuration file for the GH repos sidebar plugin. This is thus unneeded. |
Add a new config to allow skipping github repos from the display.
Repos are skipped ny name.