Skip to content

Conversation

garyng
Copy link
Contributor

@garyng garyng commented Jan 23, 2017

Using front-matter.
Get the title from a file's frontmatter, fallback to use filename if no frontmatter can be found (eg, for README file)

Not very familiar with js though, so some optimization still can be done.

@coveralls
Copy link

coveralls commented Jan 23, 2017

Coverage Status

Coverage increased (+0.7%) to 86.875% when pulling 942fad0 on garyng:master into a256019 on imfly:master.

@coveralls
Copy link

coveralls commented Jan 23, 2017

Coverage Status

Coverage increased (+0.9%) to 87.037% when pulling f9a74f8 on garyng:master into a256019 on imfly:master.

@garyng
Copy link
Contributor Author

garyng commented Jan 23, 2017

Added option to disable completely title formatting.
lodash's .startCase will remove certain characters (such as the # in C#)

todo:

  1. add option to only format folder name while preserving filename
  2. or skip formatting file name when title can be read from the file's frontmater

And not "SUMMARY.md" statically, although another file was generated
@abeggchr
Copy link
Contributor

abeggchr commented Nov 8, 2017

I am using garyngs version and it works perfectly. Very much in favour of accepting this PR.

Two review findings:

  • The complete feature is not documented in the README.md
  • The "Ignores" flag no longer compares the file names but the title from the frontmatter. It can be argued that this is logical, but then it certainly needs additional documentation about the ignores flag.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage increased (+0.9%) to 87.037% when pulling 79cf085 on garyng:master into a256019 on imfly:master.

@imfly
Copy link
Owner

imfly commented Nov 8, 2017

Thank you very much. Can you add the instructions to the ReadMe.md?

abeggchr and others added 2 commits November 9, 2017 21:02
added command line options and how the article title is derived
@coveralls
Copy link

coveralls commented Nov 9, 2017

Coverage Status

Coverage increased (+0.9%) to 87.037% when pulling 53d4f8f on garyng:master into a256019 on imfly:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 87.037% when pulling 53d4f8f on garyng:master into a256019 on imfly:master.

@garyng
Copy link
Contributor Author

garyng commented Nov 17, 2017

Added by @abeggchr. Thanks!

@imfly imfly merged commit 0399542 into imfly:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants