add 5.0.2 type definitions as fallback for TS<3.7 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@mweststrate : think you could get this into the next v6 alpha? |
|
Changed target to v6. TODO: add the new v6 api's, will see if I find some time later today |
|
Sweet, thanks! |
This was referenced Feb 27, 2020
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #538, this should allow TS versions 3.1 (which was the first version to support the
typesVersionspackage.json field) to 3.6 to fall back to the old type definitions ofimmer 5.02(which I believe is the last version ofimmerthat was compatible to pre-3.7 TS versions).I've built & packed this locally and un-tared it by hand into another project and tested it with TS 3.6.3. Without the entry in the
package.json, my produced draft evaluated toany, with it it evaluated to the correct type, so this should be working.