Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua-start-process does not allow for customization #118

Open
technomancy opened this issue Jun 6, 2016 · 3 comments
Open

lua-start-process does not allow for customization #118

technomancy opened this issue Jun 6, 2016 · 3 comments

Comments

@technomancy
Copy link

Since lua-start-process activates compilation-shell-minor-mode instead of defining its own mode, there is no way to customize the keymap it uses or add hooks. It seems like defining a derived mode would allow for a lot more flexibility.

I can submit a patch for this if you like. But I'm not sure what the best name for the mode would be; I would call it lua-repl-mode, but the term "repl" doesn't seem to be used in Lua-land. Let me know if there's a better name for it.

@immerrr
Copy link
Owner

immerrr commented Jun 7, 2016

That sounds like a great idea. I don't have anything against lua-repl-mode, let's call it like that.

@technomancy
Copy link
Author

technomancy commented Jun 8, 2016 via email

@immerrr
Copy link
Owner

immerrr commented Jun 8, 2016

Don't worry about it. The new approach looks promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants