Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm modules instead of bundling three-math.js #2

Closed
deathcap opened this issue Feb 12, 2015 · 2 comments
Closed

Use npm modules instead of bundling three-math.js #2

deathcap opened this issue Feb 12, 2015 · 2 comments

Comments

@deathcap
Copy link
Contributor

Would there be interest in converting webvr-polyfill to use various NPM modules for math instead of the included https://github.com/borismus/webvr-polyfill/blob/master/src/three-math.js? E.g.:

https://www.npmjs.com/package/gl-vec2
https://www.npmjs.com/package/gl-vec3
https://www.npmjs.com/package/gl-matrix-quat
https://www.npmjs.com/package/gl-matrix

(started working on this at https://github.com/deathcap/webvr-polyfill/tree/gl-vec3, but very incomplete)

@borismus
Copy link
Contributor

Definitely interest in further reducing the dependency on three.js. I took
the Mathy classes out of it wholesale, but in terms of code path, only
using a small fraction of the 2kb of code. It might be an easier change to
prune down three-math.js rather than re-write parts of the polyfill.

On Wed, Feb 11, 2015 at 9:26 PM, deathcap notifications@github.com wrote:

Would there be interest in converting webvr-polyfill to use various NPM
modules for math instead of the included
https://github.com/borismus/webvr-polyfill/blob/master/src/three-math.js?
E.g.:

https://www.npmjs.com/package/gl-vec2
https://www.npmjs.com/package/gl-vec3
https://www.npmjs.com/package/gl-matrix-quat
https://www.npmjs.com/package/gl-matrix

(started working on this at
https://github.com/deathcap/webvr-polyfill/tree/gl-vec3, but very
incomplete)


Reply to this email directly or view it on GitHub
#2.

@borismus
Copy link
Contributor

borismus commented May 6, 2016

See @toji's recent commit to remove three-math and replace it with math-utils.

@borismus borismus closed this as completed May 6, 2016
zazabe added a commit to zazabe/webvr-polyfill that referenced this issue May 30, 2016
Update to the latest offical master version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants