Use unsigned long for cancelAnimationFrame() #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that - was - fast 😄 |
shivamidow
pushed a commit
to shivamidow/WebKit-http
that referenced
this pull request
Jun 10, 2020
https://bugs.webkit.org/show_bug.cgi?id=212529 Reviewed by Youenn Fablet. The type of the handle returned by XRSession::requestAnimationFrame() was recently changed to unsigned long from long as there was no point in using signed integers for that. However we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle returned by requestAnimationFrame(). We landed immersive-web/webxr#1069 in the WebXR specs so we can now safely also replace signed by unsigned integers in our implementation. No new tests as there is no change in functionality. * Modules/webxr/WebXRSession.cpp: (WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids. * Modules/webxr/WebXRSession.h: Ditto. * Modules/webxr/WebXRSession.idl: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@262718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=212529 Reviewed by Youenn Fablet. The type of the handle returned by XRSession::requestAnimationFrame() was recently changed to unsigned long from long as there was no point in using signed integers for that. However we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle returned by requestAnimationFrame(). We landed immersive-web/webxr#1069 in the WebXR specs so we can now safely also replace signed by unsigned integers in our implementation. No new tests as there is no change in functionality. * Modules/webxr/WebXRSession.cpp: (WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids. * Modules/webxr/WebXRSession.h: Ditto. * Modules/webxr/WebXRSession.idl: Ditto. Canonical link: https://commits.webkit.org/225715@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=212529 Reviewed by Youenn Fablet. The type of the handle returned by XRSession::requestAnimationFrame() was recently changed to unsigned long from long as there was no point in using signed integers for that. However we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle returned by requestAnimationFrame(). We landed immersive-web/webxr#1069 in the WebXR specs so we can now safely also replace signed by unsigned integers in our implementation. No new tests as there is no change in functionality. Reland r262718. * Modules/webxr/WebXRSession.cpp: (WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids. * Modules/webxr/WebXRSession.h: Ditto. * Modules/webxr/WebXRSession.idl: Ditto. Canonical link: https://commits.webkit.org/225858@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1062 we moved from signed to unsigned integers in the return value of
requestAnimationFrame. However we forgot to do the same for the cancelAnimationFrame() as it gets the handle returned by requestAnimationFrame().Preview | Diff