feat: github status webhooks #27
Conversation
danieldietzler
force-pushed
the
webhooks
branch
3 times, most recently
from
ad14976
to
3373926
Compare
| return false; | ||
| }; | ||
|
|
||
| app.post('/github-status', async (req, res) => { |
There was a problem hiding this comment.
We can't just expose a plain endpoint for anyone to be able to post stuff to, so we'll need some way to put a secret in the URL. We can either do that here, or I can try to cook something up on the kubernetes side instead.
There was a problem hiding this comment.
Woops that's actually a good point. I was assuming you could just make assumptions about the origin, but it's quite likely that's not easily possible.
| app.use(express.json()); | ||
| app.use('/webhooks', webhooks); | ||
| app.listen(8080, () => { | ||
| console.log('Bot listening on port 8080'); | ||
| }); |
There was a problem hiding this comment.
might be good to do this before bot.login but it probably doesn't matter. also not a bad idea to listen on a port via env, but also probably doesn't matter
There was a problem hiding this comment.
I'll move it up real quick, good idea. Keeping the port hard coded should really be fine in this use case imo.
No description provided.