fix(web): no icon with firefox #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6c48fc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a18e745a.immich.pages.dev |
| Branch Preview URL: | https://fix-icon.immich.pages.dev |
jrasm91
approved these changes
Dec 13, 2023
JW-CH
pushed a commit
to JW-CH/immich
that referenced
this pull request
Dec 13, 2023
* fix: no icon with firefox * remove FaviconHeader.svelte
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* fix: no icon with firefox * remove FaviconHeader.svelte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
This PR fixes the missing favicon for the bookmark on firefox by adding the favicon mention in the plain page source. Moved the favicon assets to the static folder.
Created the favicon.ico with
convert -resize x16 -gravity center -crop 16x16+0+0 favicon.png -flatten -colors 256 -background transparent favicon.icoFixes #5676