Skip to content

Conversation

alex-connolly
Copy link
Contributor

@alex-connolly alex-connolly commented Oct 18, 2023

Aims to merge all the contracts used by Immutable X customers into our central contracts repository. Contracts sourced from:

@alex-connolly alex-connolly changed the base branch from main to v2 October 19, 2023 00:00
@alex-connolly alex-connolly changed the base branch from v2 to main October 19, 2023 01:18
@alex-connolly alex-connolly marked this pull request as ready for review October 19, 2023 06:16
@alex-connolly alex-connolly requested a review from a team October 19, 2023 06:16
@rzmahmood
Copy link
Contributor

  • Does it make sense for the version of these contracts to stay at ^0.8.x?

  • Does it make sense for us to bump the contract versions to 0.9.x when that comes out? I don't see that happening for contract like Registration.sol as it doesn't make sense to update the version of a deployed contract, causing a mismatch. This will eventually cause commands like npx hardhat compile to fail once other contracts start being written in 0.9.x. Consider what the development strategy will be then.

@carleeto carleeto self-requested a review October 29, 2023 21:25
@carleeto
Copy link
Contributor

  • Does it make sense for the version of these contracts to stay at ^0.8.x?

Yeah, I think it does for now.

  • Does it make sense for us to bump the contract versions to 0.9.x when that comes out? I don't see that happening for contract like Registration.sol as it doesn't make sense to update the version of a deployed contract, causing a mismatch. This will eventually cause commands like npx hardhat compile to fail once other contracts start being written in 0.9.x. Consider what the development strategy will be then.

Probably not. If contracts use multiple versions, we can use a hardhat config to deal with it (https://hardhat.org/hardhat-runner/docs/advanced/multiple-solidity-versions)

@carleeto carleeto merged commit e2f5dc2 into main Oct 30, 2023
@carleeto carleeto deleted the consolidation/imx-contracts branch October 30, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants