Add $schema property to config files
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesturner246
approved these changes
Aug 16, 2024
Dummy_disease_test/data/index.json
Outdated
| @@ -1,5 +1,4 @@ | |||
| { | |||
| "version": 2, | |||
There was a problem hiding this comment.
Was no schema here intentional?
There was a problem hiding this comment.
Yep. I've made two changes: one to add the $schema property and another to drop the (now-redundant) version property. Is that ok?
There was a problem hiding this comment.
Changed my mind 🙃. I'll leave the version property there for now to avoid breaking backwards compatibility. We can remove it properly when we make a new config file format.
This reverts commit 18c1416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for imperialCHEPI/healthgps#449, I've added a
$schemaproperty to each of the config files. Currently the URL doesn't exist, but it will once I've fixed that issue in the main repo (which I've nearly finished). I've dropped theversionproperty, as we no longer need it.I leave it up to you whether you want to merge before or after imperialCHEPI/healthgps#449 is fixed.