Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid additional properties in data index files #486

Closed
alexdewar opened this issue Aug 12, 2024 · 3 comments · Fixed by #509
Closed

Forbid additional properties in data index files #486

alexdewar opened this issue Aug 12, 2024 · 3 comments · Fixed by #509
Assignees

Comments

@alexdewar
Copy link
Contributor

See: #404

I initially tried setting additionalProperties to false everywhere in the schema, but it broke validation so I didn't bother. I should have opened an issue at the time though, because we do also want to prevent users from adding additional properties (at least most of the time). In part this just makes the files cleaner, but it also prevents users from changing non-existent properties that won't actually do anything (including if they misspell the name of an actual property).

@jamesturner246
Copy link
Contributor

but it also prevents users from changing non-existent properties that won't actually do anything (including if they misspell the name of an actual property).

Precisely the cause of the last fiasco. We probably want to be as pedantic as we can get away with here. 👍

@alexdewar
Copy link
Contributor Author

Oh dear. Was that with the static data or the config files?

@alexdewar alexdewar moved this from 📋 Backlog to 🔖 Ready in Health-GPS Aug 13, 2024
@alexdewar alexdewar self-assigned this Aug 13, 2024
@jamesturner246
Copy link
Contributor

That was the static relative disease risk files, in that case.

alexdewar added a commit that referenced this issue Aug 28, 2024
Also disallow additional properties in all subschemas.

Fixes #486.
alexdewar added a commit that referenced this issue Aug 28, 2024
Also disallow additional properties in all subschemas.

Fixes #486.
@alexdewar alexdewar moved this from 🔖 Ready to 👀 In review in Health-GPS Aug 29, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Health-GPS Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants