Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bot PRs need approving review before they can be merged #448

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

alexdewar
Copy link
Contributor

I missed this before, but because we have it as a requirement that PRs need an approving review, the bot PRs are still not being auto-merged.

This change should fix that.

Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Now if only there was a way to filter the tens of emails for bumping various versions each week 🤔

I missed this before, but because we have it as a requirement that PRs need an approving review, the bot PRs are still not being auto-merged.

This change should fix that.
@alexdewar alexdewar force-pushed the dependabot-automerge-needs-approval branch from a5aaee3 to aa1ebd1 Compare June 20, 2024 12:07
@alexdewar alexdewar enabled auto-merge June 20, 2024 12:08
@alexdewar alexdewar merged commit 13e9c8b into main Jun 20, 2024
5 checks passed
@alexdewar alexdewar deleted the dependabot-automerge-needs-approval branch June 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants