Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify remote executor #382

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

jsonar-cpapke
Copy link
Collaborator

@jsonar-cpapke jsonar-cpapke commented Feb 12, 2024

Related to https://onejira.imperva.com/browse/SD-1064

Standardize getting paramiko client. Create remote_client_context to return a client with or without proxy, and cleanup afterwards.

As well, added some raise from to improve debugging.

This is the prequal to using the paramiko client for more things, so simplifying how to create one is important.

@jsonar-cpapke
Copy link
Collaborator Author

I see a failure with create terraform that seems unrelated to these changes

@lindanasredin
Copy link
Collaborator

lindanasredin commented Feb 13, 2024

I see two actions failed, one failure in DAM so not related: https://github.com/imperva/dsfkit/actions/runs/7876864234/job/21491779160#step:21:10113
And one failure in upgrade in the unit tests: https://github.com/imperva/dsfkit/actions/runs/7876864231/job/21491778541#step:7:1405
The error is:
ERROR tests/test_main.py::test_main_raise_exception_on_overall_status_failed - AttributeError: <module 'upgrade.main' from '/home/runner/work/dsfkit/dsfkit/modules/aws/sonar-upgrader/python_upgrader/upgrade/main.py'> does not have the attribute 'test_connection'

This looks related to the change.

@jsonar-cpapke
Copy link
Collaborator Author

@lindanasredin I've already fixed and rerun those tests https://github.com/imperva/dsfkit/actions/runs/7877609163

@jsonar-cpapke jsonar-cpapke merged commit 7df850a into dev Feb 13, 2024
2 checks passed
@jsonar-cpapke jsonar-cpapke deleted the cpapke/simplify-remote-executor branch February 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants