Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 4.13.0.30.0 #395

Merged
merged 1 commit into from
Mar 5, 2024
Merged

adding 4.13.0.30.0 #395

merged 1 commit into from
Mar 5, 2024

Conversation

jsonar-cpapke
Copy link
Collaborator

No description provided.

@lindanasredin
Copy link
Collaborator

Please re-run the actions if they fail for unrelated reasons. I want to see green V on PRs before approval.

@lindanasredin
Copy link
Collaborator

I don't see the tarball in the S3 bucket.

@imperva-admin imperva-admin merged commit 59e7621 into dev Mar 5, 2024
5 of 6 checks passed
@imperva-admin imperva-admin deleted the cpapke/4.13.30 branch March 5, 2024 14:02
@jsonar-cpapke
Copy link
Collaborator Author

Why was this merged? As mentioned, it seems like the upload to the S3 bucket failed.

@lindanasredin
Copy link
Collaborator

We wanted to release today since customer ANZ is waiting for this patch, but eventually it may be tomorrow. So I uploaded the tarball myself. I just thought you forgot to upload it, which can easily happen to anyone, wouldn't you know if your upload failed? For example if I run a CLI command to upload the tarball, I know if it succeeded or failed in the command output.

@jsonar-cpapke
Copy link
Collaborator Author

I'm working on creating a script for this, as doing it manually is not sustainable. It had failed to upload the tarball last time though, and I only partially got it uploaded yesterday.

@lindanasredin
Copy link
Collaborator

Ok, makes sense to automate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants