Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some settings to properly reflect Enable/Disable Correctly #962

Closed
mathetos opened this issue Aug 25, 2016 · 5 comments
Closed

Change some settings to properly reflect Enable/Disable Correctly #962

mathetos opened this issue Aug 25, 2016 · 5 comments
Assignees
@mathetos @DevinWalker
Milestone
1.8

Comments

@mathetos
Copy link
Member

Throughout the plugin we often mixed the purposes of settings between Enable/Disable, or Show/Hide in ways that can cause confusion.

Here's one example:
enable-disable-settings-confusion

Three different settings, checking one enables, while checking another disables.

I propose something like the following instead:
enable-disable-settings-suggestion

This would apply to every setting that uses language like True/False or On/Off, Show/Hide, Enable/Disable. Consistency in our settings is important to the user experience.
@mathetos mathetos added this to the 1.8 milestone Aug 25, 2016
@mathetos mathetos self-assigned this Aug 25, 2016
@DevinWalker
Copy link
Member

What's the UI best practice here? I feel a checkbox is pretty easy to understand... but radios, makes sense too.

@mathetos
Copy link
Member Author

I think if it's a checkbox it needs to ALWAYS be "Enable". To check it in order to "Disable" is counterintuitive. But I think the radio buttons make it all as obvious as possible and avoid any confusion because they show ALL the options directly.

@ramiy
Copy link
Contributor

ramiy commented Aug 26, 2016

I agree with @mathetos.

Although check-boxes are simple operators, the current wording "Enable this option if you would like to disable the ..." can be very confusing. With radio button we remove the confusion factor from the equation.

@mathetos
Copy link
Member Author

mathetos commented Aug 29, 2016 •
edited
Loading

OK, here's a list of all the options on the "Donations > Settings" page tabs that need updating:

Payment Gateways Tab

  • Test Mode -- Enabled (default) | Disabled
  • "PayPal IPN Verification" -- Enabled (default) | Disabled (Enabled is default)
  • "Collect Billing Details" (Offline Donations) -- Yes | No (default)

Display Options Tab

  • "Disable CSS" change label to "Native Give Styles" -- Enable (default) | Disable
  • "Enable Floating Labels" change to "Floating Labels" -- Enable | Disable (default)
  • "Disable Welcome Screen" change to "Welcome Screen" -- Enable (default) | Disable
  • "Disable Form Single Views" change to "Form Single Views" -- Enable (default) | Disable
  • "Disable Form Archives" change to "Form Archives" -- Enable (default) | Disable
  • "Disable Form Excerpts" change to "Form Excerpts" -- Enable (default) | Disable
  • "Disable Form Featured Image" change to "Form Featured Image" -- Enable (default) | Disable
  • "Disable Single Form Sidebar" change to "Single Form Sidebar" -- Enable (default) | Disable
  • "Enable Form Categories" change to "Form Categories" -- Enable | Disable (default)
  • "Enable Form Tags" change to "Form Tags" -- Enable | Disable (default)

Emails Tab

  • "Disable Admin Notifications" change to "Admin Notifications" -- Enable (default) | Disable

Advanced Tab

  • "Email Access" -- Enable | Disable (default)
  • "Remove All Data on Uninstall" -- Yes | No (default)
  • "Disable the_content filter" change to "Single Form Content Filter" -- Enable (default) | Disable
  • "Load Scripts in Footer?" -- Yes | No (default)

Add-ons

I'll make additional issues in the respective Addons that reference this issue, but from a quick review this would apply most often to the Payment Gateways.

mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Regarding #962 -- updates to Payment Gateways Tab
c11c925
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Regarding #962 -- updates to Display Options Tab
797741c
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Regarding #962 -- updates to Email Options Tab
3f4b854
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Regarding #962 -- updates to Advanced Options Tab
4bd18cb
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Revert "Regarding #962 -- updates to Advanced Options Tab"
d3583a9 
This reverts commit 4bd18cb.
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Revert "Regarding #962 -- updates to Email Options Tab"
fd68c32 
This reverts commit 3f4b854.
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Revert "Regarding #962 -- updates to Display Options Tab"
cb2d701 
This reverts commit 797741c.
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Revert "Regarding #962 -- updates to Payment Gateways Tab"
3bd6b62 
This reverts commit c11c925.
@mathetos mathetos reopened this Aug 29, 2016
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Resolves #962
3c3ab63
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Revert "Resolves #962"
995544c 
This reverts commit 3c3ab63.
mathetos added a commit that referenced this issue Aug 29, 2016
@mathetos
Resolves #962
7937d8c
@mathetos mathetos mentioned this issue Aug 29, 2016
Closed
@mathetos mathetos mentioned this issue Aug 29, 2016
Closed
@mathetos mathetos modified the milestones: 1.7, 1.8 Aug 29, 2016
DevinWalker pushed a commit that referenced this issue Aug 30, 2016
Merge branch 'release/1.7' into issue/370
f816e22 
* release/1.7: (158 commits)
  Merge 1.6.1 into 1.7
  Update filter give_payment_gateways --> give_donation_gateways
  Move payment-->donation in actions and filters
  Update general translation POT file
  update languages redame
  Delete PO/MO language files (Give)
  Delete PO/MO language files (CMB2)
  minor composer file update
  Readme: use https links
  Revert "Resolves #962"
  Resolves #962
  Revert "Regarding #962 -- updates to Payment Gateways Tab"
  Revert "Regarding #962 -- updates to Display Options Tab"
  Revert "Regarding #962 -- updates to Email Options Tab"
  Revert "Regarding #962 -- updates to Advanced Options Tab"
  Revert "Use `show_option_none` instead of no value for CMB2 compatibility"
  Revert "Final cleanup of settings."
  Final cleanup of settings.
  Use `show_option_none` instead of no value for CMB2 compatibility
  Regarding #962 -- updates to Advanced Options Tab
  ...

# Conflicts:
#	includes/admin/class-give-settings.php
DevinWalker pushed a commit that referenced this issue Aug 30, 2016
Merge branch 'release/1.7' into issue/619
1a101c7 
* release/1.7: (29 commits)
  Merge 1.6.1 into 1.7
  Update filter give_payment_gateways --> give_donation_gateways
  Move payment-->donation in actions and filters
  Update general translation POT file
  update languages redame
  Delete PO/MO language files (Give)
  Delete PO/MO language files (CMB2)
  minor composer file update
  Readme: use https links
  Revert "Resolves #962"
  Resolves #962
  Revert "Regarding #962 -- updates to Payment Gateways Tab"
  Revert "Regarding #962 -- updates to Display Options Tab"
  Revert "Regarding #962 -- updates to Email Options Tab"
  Revert "Regarding #962 -- updates to Advanced Options Tab"
  Revert "Use `show_option_none` instead of no value for CMB2 compatibility"
  Revert "Final cleanup of settings."
  Final cleanup of settings.
  Use `show_option_none` instead of no value for CMB2 compatibility
  Regarding #962 -- updates to Advanced Options Tab
  ...
@DevinWalker DevinWalker modified the milestones: 1.8, 1.7 Sep 20, 2016
@DevinWalker DevinWalker assigned DevinWalker and mathetos and unassigned mathetos Sep 20, 2016
@DevinWalker
Copy link
Member

This is complete in release/1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathetos mathetos

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@ramiy @mathetos @DevinWalker