Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add phone number block/field to the visual form builder and donation forms #7340

Merged
merged 48 commits into from
Apr 19, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Apr 3, 2024

Resolves GIVE-532

Description

This PR adds a new Phone block to the visual form builder to allow admins to set up a form to collect the donor's phone numbers. When the donation is finished, the phone number is displayed on the confirmation page under the "Donor Details" section, it also is displayed in the edit donation screen in the wp-admin area.

Also, this PR prevents a donor with a phone number saved previously from getting this value overwritten in cases where a new donation is made with a new number - instead of overwriting the previous value, we save the new phone number only in the donation meta. instead of overwriting the previous value, we save the new phone number in the "additional phones" property.

Affects

  • The Donor model
  • The Donation Form model
  • The Visual Form Builder

Visuals

image

image

image

image

Testing Instructions

  1. Create a v3 form;
  2. Add the new Phone block;
  3. Make a test donation;
  4. On the confirmation page, check if the phone is visible in the donor details;
  5. On the donation edit page, check if the phone is displayed in the donor details section.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Apr 5, 2024
@glaubersilva glaubersilva changed the title Feature: add phone number input to visual form builder Feature: add phone number block to visual form builder Apr 8, 2024
@glaubersilva glaubersilva changed the title Feature: add phone number block to visual form builder Feature: add phone number block/field to the visual form builder and donation forms Apr 8, 2024
@glaubersilva glaubersilva marked this pull request as ready for review April 8, 2024 22:06
@JasonTheAdams
Copy link
Contributor

Yo, this looks amazing, @glaubersilva! 🤩

@glaubersilva
Copy link
Contributor Author

@jonwaldstein This is ready for re-review.

@glaubersilva
Copy link
Contributor Author

@jonwaldstein This is ready for re-review.

@glaubersilva
Copy link
Contributor Author

@jonwaldstein I did implement the last changes suggested and this is ready for re-review.

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job man! Ready for QA 🌈

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit de6ec94 into develop Apr 19, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the feature/phone-number-form-GIVE-532 branch April 19, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants