-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add phone number block/field to the visual form builder and donation forms #7340
Conversation
Yo, this looks amazing, @glaubersilva! 🤩 |
@jonwaldstein This is ready for re-review. |
src/DonationForms/resources/registrars/templates/fields/Phone.tsx
Outdated
Show resolved
Hide resolved
src/DonationForms/resources/registrars/templates/fields/Phone.tsx
Outdated
Show resolved
Hide resolved
@jonwaldstein This is ready for re-review. |
src/FormBuilder/resources/js/form-builder/src/blocks/fields/phone/settings.tsx
Outdated
Show resolved
Hide resolved
src/FormBuilder/resources/js/form-builder/src/blocks/fields/phone/index.tsx
Outdated
Show resolved
Hide resolved
src/DonationForms/resources/registrars/templates/fields/Phone.tsx
Outdated
Show resolved
Hide resolved
@jonwaldstein I did implement the last changes suggested and this is ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job man! Ready for QA 🌈
src/DonationForms/Actions/ConvertDonationFormBlocksToFieldsApi.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Resolves GIVE-532
Description
This PR adds a new Phone block to the visual form builder to allow admins to set up a form to collect the donor's phone numbers. When the donation is finished, the phone number is displayed on the confirmation page under the "Donor Details" section, it also is displayed in the edit donation screen in the wp-admin area.
Also, this PR prevents a donor with a phone number saved previously from getting this value overwritten in cases where a new donation is made with a new number - instead of overwriting the previous value, we save the new phone number only in the donation meta.
instead of overwriting the previous value, we save the new phone number in the "additional phones" property.Affects
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks