Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add donor phone number exports #7394

Merged
merged 9 commits into from
May 30, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented May 22, 2024

Resolves GIVE-771

Description

These changes update the donation and donor exports with a "Donor Phone Number" column.

  1. Donor exports will export the donors phone number which can be viewed and edited through the Donor admin screen.
    Saved in give_donor under phone

  2. Donation exports will export the Donor Phone Number field made on a donation and can be found in the Donation admin screen under Donor Details. Saved in give_donationmeta under _give_payment_donor_phone

Reference: #7340

Affects

Donation & Donor exports

Visuals

testing-donor-exports.mov
donor-exports
testing-donation-exports.mov
donation-exports

Testing Instructions

Donation Exports

  • Create a v3 form
  • Add Donor Phone Field block
  • Process a donation with the block filled out
  • Go to Donations->tools
  • Under Export Donation History click Generate csv
  • Under Donor Fields ensure Donor's Phone Number is checked
  • Click Generate csv
  • Verify that the Donor Phone Number column contains a phone number for the donation

Donor Exports

  • Go to the Donor admin screen Donations->Donors & edit a donor
  • On the next screen edit donor again
  • Add a phone number to the donor
  • Go to Tools screen Donations->Tools &
  • Ensure the Donor Phone Number column is checked
  • Click Generate csv
  • Verify that the Donor Phone Number column contains a phone number for the donor

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review May 22, 2024 17:43
@JoshuaHungDinh JoshuaHungDinh changed the title feature: add donor exports feature: add donor phone number exports May 22, 2024
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh Looks good to me. I only left a comment related to a missing unreleased tag, please add that before sending it to QA. Great work!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit a3b8cd1 into develop May 30, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/donor-phone-number-exports branch May 30, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants