Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing for repeated extension fields generated incorrectly #313

Closed
stasberkov opened this issue Dec 21, 2023 · 0 comments
Closed

Typing for repeated extension fields generated incorrectly #313

stasberkov opened this issue Dec 21, 2023 · 0 comments

Comments

@stasberkov
Copy link
Contributor

stasberkov commented Dec 21, 2023

Versions of relevant software used
ts-protoc-gen@0.15.0

What happened

I have protocol with repeated extension field i.e.

extend WebAPI_2.ClientMsg
{
  repeated RFQSubscriptionRequest rfq_subscription_requests = 206;
}

ts-protoc-gen generates typing for it as

  export const rfqSubscriptionRequests: jspb.ExtensionFieldInfo<RFQSubscriptionRequest>;

What you expected to happen

Typing should be

  export const rfqSubscriptionRequestsList: jspb.ExtensionFieldInfo<Array<RFQSubscriptionRequest>>;

Changes: 1) add "List" suffix, 2) add Array for type.

stasberkov pushed a commit to stasberkov/ts-protoc-gen that referenced this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant