-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for File Input element type #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for the contribution. Please take a look at the few comments that I've left. I'll merge the PR immediately after they are addressed.
@imryche Thanks for pointing that out. I've updated the branch with those recommended changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should inherit from the ActionableComponent
class to make the tests pass
Looks like I left a reference to focus_on_load in |
Released the changes in v1.8.0 |
Slack added a
file_input
input element type with an API update in January 2024. This PR would add support for thefile_input
element in the builder.