Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for File Input element type #110

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

cleavenworth
Copy link
Contributor

Slack added a file_input input element type with an API update in January 2024. This PR would add support for the file_input element in the builder.

Copy link
Owner

@imryche imryche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the contribution. Please take a look at the few comments that I've left. I'll merge the PR immediately after they are addressed.

blockkit/elements.py Outdated Show resolved Hide resolved
blockkit/elements.py Outdated Show resolved Hide resolved
@cleavenworth
Copy link
Contributor Author

@imryche Thanks for pointing that out. I've updated the branch with those recommended changes.

Copy link
Owner

@imryche imryche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should inherit from the ActionableComponent class to make the tests pass

@cleavenworth
Copy link
Contributor Author

Looks like I left a reference to focus_on_load in test_elements.py. I've removed that and also implemented the change to use ActionableComponent.

@imryche imryche merged commit c6777d0 into imryche:master Mar 5, 2024
5 checks passed
@imryche
Copy link
Owner

imryche commented Mar 5, 2024

Released the changes in v1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants