Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong number of newsletter subscribers in newsletter list #60

Closed
cdaecke opened this issue Oct 12, 2020 · 2 comments
Closed

Wrong number of newsletter subscribers in newsletter list #60

cdaecke opened this issue Oct 12, 2020 · 2 comments

Comments

@cdaecke
Copy link
Contributor

cdaecke commented Oct 12, 2020

As shown in the attached screenshot, the number of the newsletter subscribers in the list of all newsletters is showing the current number of subscribers and not the real number of the newsletter receivers for one newsletter.

Bildschirmfoto 2020-10-12 um 19 58 40

I will provide a pull request, which addresses this issue. It will show the numbers from the queue of a newsletter, so the real numbers a newsletter was sent to.

Bildschirmfoto 2020-10-12 um 19 48 47

Thank you a big time for this great extension!
@cdaecke cdaecke mentioned this issue Oct 12, 2020
Merged
@einpraegsam
Copy link
Collaborator

You are right, we should change this behaviour. Thx for digging into it.

cdaecke added a commit to cdaecke/luxletter that referenced this issue Oct 13, 2020
@cdaecke
[TASK] Use Newsletter::class as required argument in GetNumberOfRecei…
52ce7d9 
…versFromQueueViewHelper()

ref in2code-de#60
@einpraegsam
Copy link
Collaborator

Just merged into develop - ready for upcoming release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@einpraegsam @cdaecke