‘Ignored variable is being used’ reported for non-variables

[ddeboer]

First off, thanks for Elvis! It’s a great tool for keeping an eye on code quality.

The is_ignored_var check apparently reports this macro call as a ignored variable as well:

?__("This string will be translated. This is a common convention that we also use in the Zotonic framework."),

Can the check be adapted to exclude macros?

[JohanVikman]

@elbrujohalcon do we need to update katana for this? If katana could show that this is a macro it would be easier to fix this in elvis_core I think...

[elbrujohalcon]

@JohanVikman probably, since the code seems to be already verifying that it's in fact a variable here.
If this bug is still happening (maybe it's already fixed), it's probably a katana-code bug and it should be reported as such.

[ddeboer]

This is still a problem on the current masters of elvis and elvis_config.