Skip to content

Conversation

Umekawa
Copy link
Member

@Umekawa Umekawa commented Oct 7, 2025

What

  • Calculate and upload code coverage data to qlty during CI
  • Make code coverage and Maintainability viewable from the README

How

  • Install simplecov_json_formatter
  • Change the coverage output format to JSON
  • Implement the coverage action from qlty
  • Add a badge to the README

Why

REF

@Umekawa Umekawa requested a review from a team as a code owner October 7, 2025 09:43
@Umekawa Umekawa requested review from Copilot and getty104 and removed request for a team October 7, 2025 09:43
@Umekawa Umekawa self-assigned this Oct 7, 2025
Copy link

Summary of Changes

Hello @Umekawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates 'qlty' into the project's continuous integration pipeline to provide up-to-date metrics on code coverage and maintainability. This change is crucial for maintaining code quality standards, especially after the deprecation of the Code Climate API. The integration ensures that these vital statistics are automatically calculated and prominently displayed in the project's README, offering immediate visibility into the codebase's health.

Highlights

  • Code Quality Integration: Introduced 'qlty' for monitoring code coverage and maintainability, replacing the previously used and now disabled Code Climate API.
  • Coverage Data Format: Configured SimpleCov to output coverage data in JSON format using 'simplecov_json_formatter' to facilitate integration with 'qlty'.
  • README Badges: Added new badges to the README.md file to display the 'qlty' maintainability and code coverage status directly.
  • Development Dependency: Added 'simplecov_json_formatter' as a development dependency in the gemspec.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from Code Climate to qlty for code coverage tracking and maintainability metrics. The changes implement JSON coverage output and integrate qlty's coverage reporting workflow.

  • Added simplecov_json_formatter dependency and configured dual output (JSON + HTML)
  • Implemented qlty coverage action in CI workflow
  • Updated README badges to display qlty maintainability and coverage metrics

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
spec/spec_helper.rb Configured SimpleCov to output both JSON and HTML formats with spec filtering
ruboty-github.gemspec Added simplecov_json_formatter as development dependency
README.md Updated badges to use qlty instead of Code Climate
.github/workflows/test.yml Added qlty job for coverage upload using coverage.json output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces qlty for code coverage and maintainability metrics, replacing the now-disabled Code Climate integration. The changes correctly add the simplecov_json_formatter dependency, configure simplecov to output JSON reports, and update the README with new badges. The implementation is solid. I have a couple of minor suggestions to improve formatting and readability.

@Umekawa Umekawa merged commit 7480444 into master Oct 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants