Adds Tests and Updates Dependency #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
changed the title
This was referenced Mar 27, 2015
|
Added you as a maintainer. Just ping me when you want to publish a version and I'll put it out on npm. I made this |
|
Sweet. Thanks! 👍 |
nelsonic
added a commit
to dwyl/terminate
that referenced
this pull request
Apr 15, 2015
nelsonic
added a commit
to dwyl/faster
that referenced
this pull request
Apr 15, 2015
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @indexzero
As discussed in #10
This PR adds tests (using Tape and Istanbul).
Also put in some badges at the bottom of the Readme (let me know if you prefer not to have them).
( Resisted the urge to add semicolons to the code) 😉
Happy to be co-maintainer if you and @dominictarr don't have time.
Hope you have a good weekend!
N 👍