Add google drive conversion #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Apr 8, 2024
|
Okay, now it seems to work! Should I open a PR against indico with the template change: indico/indico@8af9fe7 |
|
Hi @ThiefMaster - is there anything else I need to do here? I think I managed to run all the tests locally now. |
ThiefMaster
reviewed
Apr 9, 2024
ThiefMaster
reviewed
Apr 15, 2024
- split add_form_fields into file and URL versions - placeholders for future conversion
Remove printouts
Remove printouts
Suggestion from PR Co-authored-by: Adrian <adrian@planetcoding.net>
Co-authored-by: Adrian <adrian@planetcoding.net>
ThiefMaster
force-pushed
the
add-google-conversion
branch
from
a59c4ec
to
ec0a8fd
Compare
otherwise it's between cloudconvert stuff...
never needed for stdlib
ThiefMaster
approved these changes
Jun 13, 2024
|
Not sure how easy it is, but I'd switch the order of the flash messages: |
|
I agree that it'd be nicer, but I think it's out of scope of this PR since it's most likely the same order when uploading a file, and due to the way it's implemented it might also be very tricky to actually change the order. |
tomasr8
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in indico/indico#6045 this adds the ability to request Google to return a pdf version of a google drive link (it requires an API key, and also the following change to indico)
cc @ThiefMaster