Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign oidc-agent clients to whom approved it #817

Closed
wants to merge 13 commits into from
Closed

Assign oidc-agent clients to whom approved it #817

wants to merge 13 commits into from

Conversation

enricovianello
Copy link
Member

@enricovianello enricovianello commented Jul 25, 2024 •
edited by federicaagostini
Loading

If a user approved a client with name prefix oidc-agent:, it will be automatically linked to the user.

This should have been enabled for the device and authorization code flows.

@federicaagostini federicaagostini mentioned this pull request Jul 26, 2024
Open
@enricovianello enricovianello linked an issue Jul 31, 2024 that may be closed by this pull request
oidc-agent clients do not appear in My clients tab #652
Open
rmiccoli
rmiccoli requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@rmiccoli rmiccoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test that fails is due to a constraint on a column of a mysql table (not h2). Consider correcting/eliminating the test if not necessary

@federicaagostini
Copy link
Contributor

The test that fails is due to a constraint on a column of a mysql table (not h2). Consider correcting/eliminating the test if not necessary

Test removed, as it will never be reproducible in production due to mysql constraint.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@federicaagostini
Copy link
Contributor

Superseded by #821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmiccoli rmiccoli rmiccoli approved these changes

Assignees

@federicaagostini federicaagostini

Labels
status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oidc-agent clients do not appear in My clients tab
3 participants
@enricovianello @federicaagostini @rmiccoli