Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

No mIRC colors when using solarized theme #32

Closed
sdegrande opened this issue Jul 8, 2014 · 9 comments
Closed

No mIRC colors when using solarized theme #32

sdegrande opened this issue Jul 8, 2014 · 9 comments

Comments

@sdegrande
Copy link

Ansi colors in messages are not displayed when using the solarized theme. Only italic and bold is displayed correctly.

Thx for your work.

@indrora
Copy link
Owner

indrora commented Jul 21, 2014

Please confirm this happens on 1.18

@sdegrande
Copy link
Author

Actually, with 1.18, ansi colors are not displayed (no matter the chosen theme) as soon as «display colors to highlight specific events» (i don't know how this option is called in English, my interface is in French) is enabled. Even with default theme, dark or not.

When the option is disabled, everything is fine.

Thanks for your work.

@indrora
Copy link
Owner

indrora commented Jul 22, 2014

When you say ANSI colors, are you referring to the mIRC color spec or ANSI Color escapes?

@sdegrande
Copy link
Author

Ah yes sorry. That's mirc color codes (<ctrl+c>3 for green, and so on).
Sorry again for the confusion.

@sdegrande
Copy link
Author

Mhhh... I meant < ctrl + c >3
(I hope github will not remove it, with blanks inserted)

@sdegrande sdegrande changed the title No ansi colors when using solarized theme No mIRC colors when using solarized theme Jul 22, 2014
@indrora
Copy link
Owner

indrora commented Jul 22, 2014

This looks like a side effect of cleaning up message rendering.

indrora added a commit that referenced this issue Jul 23, 2014
Working out bug #32 (mIRC colors have a hard time). This should clear up the problems that #32 was describing.
@indrora
Copy link
Owner

indrora commented Aug 18, 2014

Can I get confirmation that this is resolved in HEAD?

@sdegrande
Copy link
Author

Sorry, I can not build it myself, and so I can not check the current git version.

@MSEMJEJME
Copy link

Haven't been able to duplicate

Sent from my Windows Phone


From: Morgan Gangweremailto:notifications@github.com
Sent: ‎18/‎08/‎2014 23:06
To: indrora/Atomicmailto:Atomic@noreply.github.com
Subject: Re: [Atomic] No mIRC colors when using solarized theme (#32)

Can I get confirmation that this is resolved in HEAD?


Reply to this email directly or view it on GitHub:
#32 (comment)

@indrora indrora closed this as completed Sep 23, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants