Skip to content

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Jun 7, 2025

This enables pyright and fixed a lot of errors that it complained about (mainly around override and class variables).

@alexfikl
Copy link
Contributor Author

alexfikl commented Jun 7, 2025

I can't see anything in here that would cause those loopy failures. Unrelated? Any ideas? :\

@inducer
Copy link
Owner

inducer commented Jun 7, 2025

Yes, totally unrelated. Loopy CI got broken by inducer/islpy#150 and then broken a bit more by inducer/pymbolic#186. It'll get fixed up by inducer/loopy#937. As long as it's just the same three tests that are broken, I'm not worried.

@inducer
Copy link
Owner

inducer commented Jun 8, 2025

This should pass once pyopencl 2025.2 (which I've just released) is on conda-forge. Optimistically tomorrow.

@alexfikl
Copy link
Contributor Author

alexfikl commented Jun 8, 2025

This should pass once pyopencl 2025.2 (which I've just released) is on conda-forge. Optimistically tomorrow.

Thanks!

@inducer
Copy link
Owner

inducer commented Jun 8, 2025

@alexfikl
Copy link
Contributor Author

alexfikl commented Jun 9, 2025

conda-forge/pyopencl-feedstock#130

Woo 🎉

loopy still seems unhappy though, with the same 3 errors as far as I can tell? From my reading of

Differences (unified diff with -expected +actual):
    @@ -1,6 +1,9 @@
     #define lid(N) ((int) get_local_id(N))
    -...
    +#define gid(N) ((int) get_group_id(N))
    +<BLANKLINE>
    +__kernel void __attribute__ ((reqd_work_group_size(1, 1, 1))) loopy_kernel(__global float *__restrict__ a, int const n)
    +{
       for (int i_outer = 0; i_outer <= -1 + (15 + n) / 16; ++i_outer)
    -    for (int i_inner = 0; i_inner <= ((-17 + n + -16 * i_outer >= 0) ? 15 : -1 + n + -16 * i_outer); ++i_inner)
    +    for (int i_inner = 0; i_inner <= ((-16 + n + -16 * i_outer >= 0) ? 15 : -1 + n + -16 * i_outer); ++i_inner)
           a[16 * i_outer + i_inner] = (float) (0.0f);
    -...
    +}

it seems like there's a change in behavior.. that -17 became a -16. Is that ok?

EDIT: Just noticed the loopy PR isn't merged yet! Nevermind :D

@inducer
Copy link
Owner

inducer commented Jun 9, 2025

it seems like there's a change in behavior.. that -17 became a -16.

Yes, there is.

Is that ok?

Good question! This had me concerned, too, so I looked at these changes quite carefully. It turns out it's equivalent.

@inducer inducer merged commit 38235c7 into inducer:main Jun 13, 2025
17 of 18 checks passed
@alexfikl alexfikl deleted the basedpyright branch June 14, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants