Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center icon (like for login page) in other pages too #68

Closed

Conversation

rowanthorpe
Copy link
Contributor

The icon is centred in the login view, and seems like it should be centred the same way in the lost-password, lost-username and reset-password views too. This PR centres the icon with the same markup as is used in the login view.

@barryo
Copy link
Member

barryo commented Sep 18, 2013

I need to test this on @rowanthorpe - the following code is primarily responsible for positioning:

<div class="span6 {if isset( $options.identity.biglogoconf.offset )}{$options.identity.biglogoconf.offset}{/if}">

and the other pages look centered to me. It's probably fine, I just want to test.

@rowanthorpe
Copy link
Contributor Author

OK. I guess then it is a question of either

  • those files needing the <p align="center"> added, or
  • the login view needing it removed...

FWIW: I am using smaller icons here, and centring definitely looks better than a static offset for me (even using font-size-based offsets won't be so reliably "centred" through varying zoom levels and browser window sizes...).

For consistency I just mimicked what was in login.phtml, but I realise positioning should be left to CSS. I guess I should really be using style="margin-left:auto; margin-right: auto" instead of that align attribute. If you prefer to stick with offsets rather than centring I will just keep centre-styling in my own skin files.

@rowanthorpe
Copy link
Contributor Author

Just for reference, I've decided to use this version myself for now: https://gist.github.com/rowanthorpe/c1fe7398139912aefad6

@bcix
Copy link
Contributor

bcix commented Sep 19, 2013

Hi, with the current code, it looks like this, really need some fixing: http://www.bcix.de/ixp/auth/login

@barryo barryo closed this in abd3b08 Feb 1, 2014
barryo added a commit that referenced this pull request Feb 1, 2014
@barryo
Copy link
Member

barryo commented Feb 1, 2014

Turns out the logo we were using at INEX has a lot of right hand side margin which through off the centering. The following is now obsolute and has been removed:

;; offset to use on auth pages (Bootstrap CSS classes)
identity.biglogoconf.offset = offset4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants