Allow missing elements when destructuring arrays in foreach loops #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
reviewed
Oct 9, 2023
| Assert::allNotNull($node->items); | ||
| $parent = $node->getAttribute('parent'); | ||
| // Don't mutate destructured values in foreach loops | ||
| if ($parent instanceof Node\Stmt\Foreach_ && $parent->valueVar === $node) { |
There was a problem hiding this comment.
Shouldn't it be in the canMutate() method below? Since there we are deciding whether to mutate Node or not
There was a problem hiding this comment.
Sorry, I totally overlooked that method. An update is on its way.
maks-rafalko
approved these changes
Oct 9, 2023
github-merge-queue bot
referenced
this pull request
in Lendable/clock
Oct 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [infection/infection](https://togithub.com/infection/infection) | `^0.27.3` -> `^0.27.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [php-cs-fixer/shim](https://togithub.com/PHP-CS-Fixer/shim) | `^3.34.0` -> `^3.34.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [phpstan/phpstan](https://togithub.com/phpstan/phpstan) | `^1.10.37` -> `^1.10.38` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [phpunit/phpunit](https://phpunit.de/) ([source](https://togithub.com/sebastianbergmann/phpunit)) | `^10.3.5` -> `^10.4.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>infection/infection (infection/infection)</summary> ### [`v0.27.4`](https://togithub.com/infection/infection/releases/tag/0.27.4): Allow missing elements when destructuring arrays in foreach loops [Compare Source](https://togithub.com/infection/infection/compare/0.27.3...0.27.4) **Fixed:** - Allow missing elements when destructuring arrays in foreach loops by [@​MidnightDesign](https://togithub.com/MidnightDesign) in [https://github.com/infection/infection/pull/1880](https://togithub.com/infection/infection/pull/1880) **Full Changelog**: infection/infection@0.27.3...0.27.4 </details> <details> <summary>PHP-CS-Fixer/shim (php-cs-fixer/shim)</summary> ### [`v3.34.1`](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.34.0...v3.34.1) [Compare Source](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.34.0...v3.34.1) </details> <details> <summary>phpstan/phpstan (phpstan/phpstan)</summary> ### [`v1.10.38`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.38) [Compare Source](https://togithub.com/phpstan/phpstan/compare/1.10.37...1.10.38) # Improvements 🔧 - Remove function signatures that were removed in PHP 8.0 ([#​2662](https://togithub.com/phpstan/phpstan-src/pull/2662)), [#​9954](https://togithub.com/phpstan/phpstan/issues/9954), thanks [@​Th3Cod3](https://togithub.com/Th3Cod3)! # Bugfixes 🐛 - Update BetterReflection - Fix for non-backed enums (ondrejmirtes/BetterReflection@4dd0f2b) - Do not invalidate types passed by value (phpstan/phpstan-src@0b8dca7), [https://github.com/phpstan/phpstan/discussions/9927](https://togithub.com/phpstan/phpstan/discussions/9927) - Do not influence types of arguments before the function is called (phpstan/phpstan-src@c45d42d) - Fixed collapsing of constant arrays (phpstan/phpstan-src@746de74), [#​9985](https://togithub.com/phpstan/phpstan/issues/9985) # Internals 🔍 - Lazier type-resolving in `isset` checks ([#​2664](https://togithub.com/phpstan/phpstan-src/pull/2664)), thanks [@​staabm](https://togithub.com/staabm)! - Refactor to invalidate args inside `processArgs` (phpstan/phpstan-src@52eb6f8) - Merge array types a bit later (phpstan/phpstan-src@adbc35a) </details> <details> <summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary> ### [`v10.4.1`](https://togithub.com/sebastianbergmann/phpunit/compare/10.4.0...10.4.1) [Compare Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.4.0...10.4.1) ### [`v10.4.0`](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.5...10.4.0) [Compare Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.5...10.4.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/clock). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ben Challis <ben@lendable.co.uk>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This fixes a bug where Infection threw an exception when generating mutations for a codebase containing
<?php foreach ($items as [, $value]) { }.The issue was an assertion that checked whether all elements in
Array_#$itemswere non-null.I'm not sure this is the ideal solution for this problem. Maybe we do want to generate mutants in this position. But for now, it will at least no longer throw.
If I just removed the assertion and widened the argument type on
getItemsIndexes, then it would generate a mutant removing the empty first element, but I'm unsure whether that's an interesting mutation to have.