Skip to content

Refactor Logical Constraints to use := #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 29, 2023
Merged

Refactor Logical Constraints to use := #91

merged 9 commits into from
Oct 29, 2023

Conversation

pulsipher
Copy link
Collaborator

@pulsipher pulsipher commented Oct 27, 2023

Closes #83. I also improved the testing coverage a bit.

@pulsipher pulsipher requested a review from hdavid16 October 27, 2023 21:57
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04334c9) 98.84% compared to head (da709c7) 99.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   98.84%   99.89%   +1.05%     
==========================================
  Files          10       10              
  Lines         952      963      +11     
==========================================
+ Hits          941      962      +21     
+ Misses         11        1      -10     
Files Coverage Δ
src/constraints.jl 100.00% <100.00%> (+1.16%) ⬆️
src/datatypes.jl 100.00% <ø> (ø)
src/macros.jl 100.00% <100.00%> (+3.10%) ⬆️
src/reformulate.jl 100.00% <100.00%> (ø)
src/variables.jl 100.00% <ø> (+1.40%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hdavid16 hdavid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@pulsipher pulsipher merged commit b26e1ed into master Oct 29, 2023
@pulsipher pulsipher deleted the logic_set branch October 29, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new := logical constraint syntax used by JuMP
2 participants