Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

New apps have both .babelrc and babel.config.js #249

Closed
bryanstearns opened this issue Sep 1, 2019 · 1 comment · Fixed by #264
Closed

New apps have both .babelrc and babel.config.js #249

bryanstearns opened this issue Sep 1, 2019 · 1 comment · Fixed by #264
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@bryanstearns
Copy link
Member

  1. ignite new MyApp
  2. cd MyApp
  3. $ ls -a | grep babel shows
.babelrc
babel.config.js

@prieto Yordis Prieto pointed this out in the community slack.

I created a new project with react-native init - it creates babel.config.js.

Then I looked at Bowser's boilerplate.js - after running react-native init, it removes .babelrc, then adds its own from its template.

After reading up on Babel configuration, and considering how RN thinks that babel.config.js is the standard (and more flexible since it's Javascript), I think Bowser's template .babelrc should be converted to babel.config.js.
@bryanstearns bryanstearns added bug Something isn't working good first issue Good for newcomers labels Sep 1, 2019
mikaoelitiana pushed a commit to mikaoelitiana/ignite-bowser that referenced this issue Oct 7, 2019
replace .babelrc with babel.config.js
f14a412 
fixes infinitered#249
@mikaoelitiana mikaoelitiana mentioned this issue Oct 7, 2019
Merged
jamonholmgren pushed a commit that referenced this issue Oct 7, 2019
@mikaoelitiana @jamonholmgren
fix(boilerplate): replace .babelrc with babel.config.js - fixes #249 (#…
352cb79 
…264 by @mikaoelitiana)
infinitered-circleci pushed a commit that referenced this issue Oct 7, 2019
@semantic-release-bot
chore(release): 4.7.3 [skip ci]
ad289f6 
## [4.7.3](v4.7.2...v4.7.3) (2019-10-07)

### Bug Fixes

* **boilerplate:** replace .babelrc with babel.config.js - fixes [#249](#249) ([#264](#264) by [@mikaoelitiana](https://github.com/mikaoelitiana)) ([352cb79](352cb79))
@infinitered-circleci
Copy link

🎉 This issue has been resolved in version 4.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace .babelrc with babel.config.js mikaoelitiana/ignite-bowser
2 participants
@bryanstearns @infinitered-circleci