Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Add a few more Reactotron mocks, to make Typescript happier #104

Merged

Conversation

bryanstearns
Copy link
Member

With a newly-generated project, typescript was complaining about src/services/reactotron/reactotron.ts:

Type '{ configure: () => any; connect: () => any; use: () => any; useReactNative: () => any; clear: () => any; log: () => any; logImportant: () => any; display: () => any; error: () => any; image: () => any; reportError: () => any; }' is not assignable to type 'Reactotron'.
  Property 'close' is missing in type '{ configure: () => any; connect: () => any; use: () => any; useReactNative: () => any; clear: () => any; log: () => any; logImportant: () => any; display: () => any; error: () => any; image: () => any; reportError: () => any; }'.

Once I added close, it complained about warn, then benchmark, so I added those too.

I also sorted the list, because I’m OCD that way.

Added benchmark, close, and warn; sorted too, because I’m OCD that way.
@bryanstearns bryanstearns merged commit afd34f3 into infinitered:master Sep 25, 2018
@bryanstearns bryanstearns deleted the add-missing-reactotron-mocks branch September 25, 2018 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants